Chromium Code Reviews| Index: net/socket/server_socket.h |
| diff --git a/net/socket/server_socket.h b/net/socket/server_socket.h |
| index 11151eea1539636928b64aee65876dfacd9e60ec..498cb0be1f09666555e6de1d98ed8e6d155c2d70 100644 |
| --- a/net/socket/server_socket.h |
| +++ b/net/socket/server_socket.h |
| @@ -5,6 +5,8 @@ |
| #ifndef NET_SOCKET_SERVER_SOCKET_H_ |
| #define NET_SOCKET_SERVER_SOCKET_H_ |
| +#include <string> |
| + |
| #include "base/memory/scoped_ptr.h" |
| #include "net/base/completion_callback.h" |
| #include "net/base/net_export.h" |
| @@ -16,17 +18,25 @@ class StreamSocket; |
| class NET_EXPORT ServerSocket { |
| public: |
| - ServerSocket() { } |
| - virtual ~ServerSocket() { } |
| + ServerSocket(); |
| + virtual ~ServerSocket(); |
| - // Bind the socket and start listening. Destroy the socket to stop |
| + // Binds the socket and start listening. Destroy the socket to stop |
|
Jana
2014/07/08 02:15:40
Nit: "start" -> "starts"
byungchul
2014/07/08 03:43:22
Done.
|
| // listening. |
| virtual int Listen(const net::IPEndPoint& address, int backlog) = 0; |
| + // Binds the socket with address and port, and starts listening. It expects |
| + // a vaild IPv4 or IPv6 address. Otherwise, it returns ERR_ADDRESS_INVALID. |
|
Jana
2014/07/08 02:15:40
Nit: "vaild" -> "valid"
byungchul
2014/07/08 03:43:22
Done.
|
| + // Subclasses may override this function if |address_string| is in a different |
| + // format, for example, unix domain socket path. |
| + virtual int ListenWithAddressAndPort(const std::string& address_string, |
| + int port, |
| + int backlog); |
| + |
| // Gets current address the socket is bound to. |
| virtual int GetLocalAddress(IPEndPoint* address) const = 0; |
| - // Accept connection. Callback is called when new connection is |
| + // Accepts connection. Callback is called when new connection is |
| // accepted. |
| virtual int Accept(scoped_ptr<StreamSocket>* socket, |
| const CompletionCallback& callback) = 0; |