Refactor tcp socket and unix domain socket.

net/socket/unix_domain_server_socket_posix.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef NET_SOCKET_UNIX_DOMAIN_SERVER_SOCKET_POSIX_H_
+#define NET_SOCKET_UNIX_DOMAIN_SERVER_SOCKET_POSIX_H_
+
+#include <string>
+
+#include "base/basictypes.h"

[mmenke, 2014/06/26 15:36:12]

nit:  include macros.h instead, to make sure we get OVERRIDE and
DISALLOW_COPY_AND_ASSIGN.

[byungchul, 2014/06/26 18:09:24]

Done.

+#include "net/base/net_export.h"
+#include "net/socket/server_socket.h"
+#include "net/socket/socket_descriptor.h"
+
+namespace net {
+
+class SocketLibevent;
+
+// Unix Domain Server Socket Implementation. Supports abstract namespaces on
+// Linux.
+class NET_EXPORT UnixDomainServerSocket : public ServerSocket {
+ public:
+  // Callback that returns whether the already connected client, identified by
+  // its process |user_id| and |group_id|, is allowed to keep the connection
+  // open. Note that the socket is closed immediately in case the callback
+  // returns false.
+  typedef base::Callback<bool (uid_t user_id, gid_t group_id)> AuthCallback;

[mmenke, 2014/06/26 15:36:12]

Should include callback.h or callback_forward.h.

[byungchul, 2014/06/26 18:09:24]

Done.

+
+  UnixDomainServerSocket(const AuthCallback& auth_callack,
+                         bool use_abstract_namespace);
+  virtual ~UnixDomainServerSocket();
+
+  // Gets UID and GID of peer to check permissions.
+  static bool GetPeerIds(SocketDescriptor socket_fd,
+                         uid_t* user_id,
+                         gid_t* group_id);

[mmenke, 2014/06/26 15:36:12]

You should include the headers for uid_t and git_t.

[byungchul, 2014/06/26 18:09:24]

Done.

+
+  // ServerSocket implementation.
+  virtual int Listen(const IPEndPoint& address, int backlog) OVERRIDE;
+  virtual int ListenWithAddressAndPort(const std::string& unix_domain_path,
+                                       int port_unused,
+                                       int backlog) OVERRIDE;
+  virtual int GetLocalAddress(IPEndPoint* address) const OVERRIDE;
+  virtual int Accept(scoped_ptr<StreamSocket>* socket,
+                     const CompletionCallback& callback) OVERRIDE;
+ private:

[mmenke, 2014/06/26 15:36:12]

nit:  Blank line before private.

[byungchul, 2014/06/26 18:09:24]

Done.

+  void AcceptCompleted(scoped_ptr<StreamSocket>* socket,
+                       const CompletionCallback& callback,
+                       int rv);
+  bool AuthenticateAndGetStreamSocket(scoped_ptr<StreamSocket>* socket);
+
+  scoped_ptr<SocketLibevent> listen_socket_;
+  const AuthCallback auth_callback_;
+  const bool use_abstract_namespace_;
+
+  scoped_ptr<SocketLibevent> accept_socket_;

[mmenke, 2014/06/26 15:36:12]

nit:  Include base/memory/scoped_ptr.h (Parent interface uses it, but think it's
best to make dependencies explicit)

[byungchul, 2014/06/26 18:09:24]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(UnixDomainServerSocket);
+};
+
+}  // namespace net
+
+#endif  // NET_SOCKET_UNIX_DOMAIN_SOCKET_POSIX_H_