Issue 348743006: Outline ContentSecurityPolicy::document()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348743006: Outline ContentSecurityPolicy::document() (Closed)

Created:
6 years, 6 months ago by philipj_slow

Modified:
6 years, 6 months ago

Reviewers:
Mike West

CC:
abarth-chromium, arv+blink, blink-reviews, blink-reviews-bindings_chromium.org, blink-reviews-html_chromium.org, dglazkov+blink, eric.carlson_apple.com, falken, fs, gasubic, horo+watch_chromium.org, kinuko+worker_chromium.org, philipj_slow, nessy, vcarbune.chromium

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

More Reviews

Description

Outline ContentSecurityPolicy::document() This allows the Document.h include to be removed from ContentSecurityPolicy.h, which reduces recompilation when touching Document.h from 1156 to 1101 steps locally. Since document() was only used internally, make it private. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176856

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -4 lines)			Patch
M	Source/bindings/v8/V8Binding.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/frame/csp/CSPDirectiveList.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/frame/csp/ContentSecurityPolicy.h	View	3 chunks	+3 lines, -2 lines	0 comments	Download
M	Source/core/frame/csp/ContentSecurityPolicy.cpp	View	1 chunk	+5 lines, -0 lines	0 comments	Download
M	Source/core/html/HTMLTrackElement.cpp	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	Source/core/workers/DedicatedWorkerGlobalScope.cpp	View	1 chunk	+3 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/philipj@opera.com/348743006/1

6 years, 6 months ago (2014-06-24 15:21:09 UTC) #3

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_gpu_triggered_tests on tryserver.chromium.gpu ...

6 years, 6 months ago (2014-06-24 16:09:59 UTC) #4

Message was sent while issue was closed.

Change committed as 176856

Expand Messages | Collapse Messages