Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(97)

Issue 348703002: Remove hooks until Windows performance issues are sorted. (Closed)

Created:
6 years, 6 months ago by szager1
Modified:
6 years, 6 months ago
Reviewers:
Ryan Tseng, iannucci, hinoka
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org, ilevy-cc_chromium.org
Visibility:
Public.

Description

Remove hooks until Windows performance issues are sorted. R=iannucci@chromium.org,hinoka@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=278717

Patch Set 1 #

Total comments: 1

Patch Set 2 : #

Total comments: 2

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -4 lines) Patch
M gclient_scm.py View 1 2 3 chunks +13 lines, -4 lines 0 comments Download
M tests/gclient_scm_test.py View 1 2 chunks +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Tseng
https://codereview.chromium.org/348703002/diff/1/gclient_scm.py File gclient_scm.py (right): https://codereview.chromium.org/348703002/diff/1/gclient_scm.py#newcode389 gclient_scm.py:389: self._Clone(revision, url, options) This will still drop hooks on ...
6 years, 6 months ago (2014-06-19 23:22:17 UTC) #1
szager1
PTAL
6 years, 6 months ago (2014-06-19 23:28:52 UTC) #2
iannucci
https://chromiumcodereview.appspot.com/348703002/diff/20001/gclient_scm.py File gclient_scm.py (right): https://chromiumcodereview.appspot.com/348703002/diff/20001/gclient_scm.py#newcode333 gclient_scm.py:333: self._DisableHooks() Will this still run for unmanaged repos? If ...
6 years, 6 months ago (2014-06-19 23:31:43 UTC) #3
szager1
https://chromiumcodereview.appspot.com/348703002/diff/20001/gclient_scm.py File gclient_scm.py (right): https://chromiumcodereview.appspot.com/348703002/diff/20001/gclient_scm.py#newcode333 gclient_scm.py:333: self._DisableHooks() On 2014/06/19 23:31:42, iannucci wrote: > Will this ...
6 years, 6 months ago (2014-06-20 00:49:39 UTC) #4
Ryan Tseng
lgtm
6 years, 6 months ago (2014-06-20 00:51:02 UTC) #5
iannucci
lgtm
6 years, 6 months ago (2014-06-20 01:01:45 UTC) #6
szager1
The CQ bit was checked by szager@chromium.org
6 years, 6 months ago (2014-06-20 15:52:14 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/szager@chromium.org/348703002/40001
6 years, 6 months ago (2014-06-20 15:52:59 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 15:55:08 UTC) #9
Message was sent while issue was closed.
Change committed as 278717

Powered by Google App Engine
This is Rietveld 408576698