Issue 348673003: Add option to provision_devices script to disable location.

Issue 348673003: Add option to provision_devices script to disable location. (Closed)

Created:
6 years, 6 months ago by navabi

Modified:
6 years, 6 months ago

Reviewers:
Ted C, bulach, tonyg, jbudorick, newt (away)

CC:
chromium-reviews, klundberg+watch_chromium.org, bulach+watch_chromium.org, yfriedman+watch_chromium.org, ilevy-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add option to provision_devices script to disable location. BUG=385379, 379219 R=tedchoc@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278556

Patch Set 2 : Fixed comment. #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+22 lines, -5 lines)			Patch
	M	build/android/provision_devices.py	View		2 chunks	+8 lines, -2 lines	0 comments	Download
	M	build/android/pylib/device_settings.py	View	1	2 chunks	+14 lines, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

Ted C

lgtm https://codereview.chromium.org/348673003/diff/1/build/android/pylib/device_settings.py File build/android/pylib/device_settings.py (right): https://codereview.chromium.org/348673003/diff/1/build/android/pylib/device_settings.py#newcode59 build/android/pylib/device_settings.py:59: # Ensure Geolocation is enabled and allowed for ...

6 years, 6 months ago (2014-06-19 22:55:54 UTC) #2

navabi

https://codereview.chromium.org/348673003/diff/1/build/android/pylib/device_settings.py File build/android/pylib/device_settings.py (right): https://codereview.chromium.org/348673003/diff/1/build/android/pylib/device_settings.py#newcode59 build/android/pylib/device_settings.py:59: # Ensure Geolocation is enabled and allowed for tests. ...

6 years, 6 months ago (2014-06-19 23:10:45 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/navabi@google.com/348673003/20001

6 years, 6 months ago (2014-06-19 23:12:53 UTC) #5

navabi

6 years, 6 months ago (2014-06-20 00:49:58 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 manually as r278556 (presubmit successful).

Expand Messages | Collapse Messages