Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issue 348623006: Add GYP target for sk_tool_utils.* component. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Add GYP target for sk_tool_utils.* component. This declares a static library target in gyp/sk_tool_utils.gyp, so other targets can depend directly on it instead of including the source file in their source lists. BUG=None TEST=make all R=mtklein@google.com Committed: https://skia.googlesource.com/skia/+/2010891425f10257363ae6eb0da70453746dc087

Patch Set 1 : #

Total comments: 2

Patch Set 2 : tools.gyp #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -13 lines) Patch
M gyp/SampleApp.gyp View 1 2 chunks +1 line, -3 lines 0 comments Download
M gyp/bench.gyp View 1 2 chunks +1 line, -1 line 0 comments Download
M gyp/tests.gypi View 1 2 chunks +1 line, -2 lines 0 comments Download
M gyp/tools.gyp View 1 2 chunks +13 lines, -2 lines 0 comments Download
M tools/sk_tool_utils.h View 2 chunks +7 lines, -4 lines 0 comments Download
M tools/sk_tool_utils.cpp View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
tfarina
6 years, 6 months ago (2014-06-19 23:25:15 UTC) #1
mtklein
https://codereview.chromium.org/348623006/diff/40001/gyp/sk_tool_utils.gyp File gyp/sk_tool_utils.gyp (right): https://codereview.chromium.org/348623006/diff/40001/gyp/sk_tool_utils.gyp#newcode8 gyp/sk_tool_utils.gyp:8: 'target_name': 'sk_tool_utils', Can this also not go in tools.gyp?
6 years, 6 months ago (2014-06-20 01:05:24 UTC) #2
tfarina
https://codereview.chromium.org/348623006/diff/40001/gyp/sk_tool_utils.gyp File gyp/sk_tool_utils.gyp (right): https://codereview.chromium.org/348623006/diff/40001/gyp/sk_tool_utils.gyp#newcode8 gyp/sk_tool_utils.gyp:8: 'target_name': 'sk_tool_utils', On 2014/06/20 01:05:24, mtklein wrote: > Can ...
6 years, 6 months ago (2014-06-20 02:37:37 UTC) #3
mtklein
On 2014/06/20 02:37:37, tfarina wrote: > https://codereview.chromium.org/348623006/diff/40001/gyp/sk_tool_utils.gyp > File gyp/sk_tool_utils.gyp (right): > > https://codereview.chromium.org/348623006/diff/40001/gyp/sk_tool_utils.gyp#newcode8 > ...
6 years, 6 months ago (2014-06-20 03:32:58 UTC) #4
tfarina
Mike, could you take another look?
6 years, 6 months ago (2014-06-21 00:29:15 UTC) #5
mtklein
lgtm
6 years, 6 months ago (2014-06-21 13:28:03 UTC) #6
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-21 17:38:27 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/tfarina@chromium.org/348623006/60001
6 years, 6 months ago (2014-06-21 17:39:16 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-21 17:54:21 UTC) #9
Message was sent while issue was closed.
Change committed as 2010891425f10257363ae6eb0da70453746dc087

Powered by Google App Engine
This is Rietveld 408576698