Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(745)

Issue 348623002: Add missing map check to optimized f.apply(...) (Closed)

Created:
6 years, 6 months ago by Jarin
Modified:
6 years, 6 months ago
CC:
v8-dev
Visibility:
Public.

Description

Add missing map check to optimized f.apply(...) This is a cutdown version of https://codereview.chromium.org/346473002/, which aimed to fix f.call and f.apply. Optimized f.call was removed by r21887, this is what was left. BUG=386034 LOG=N R=bmeurer@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21907

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -8 lines) Patch
M src/hydrogen.cc View 2 chunks +4 lines, -2 lines 0 comments Download
A + test/mjsunit/regress/regress-386034.js View 1 chunk +9 lines, -6 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Jarin
6 years, 6 months ago (2014-06-19 18:44:23 UTC) #1
Benedikt Meurer
LGTM
6 years, 6 months ago (2014-06-23 05:16:45 UTC) #2
Jarin
6 years, 6 months ago (2014-06-23 05:50:14 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r21907 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698