android_webview/browser/browser_view_renderer.cc - Issue 348613004: aw: Fix hardware teardown race

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/browser_view_renderer.cc

Issue 348613004: aw: Fix hardware teardown race (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: review Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/browser_view_renderer.cc

diff --git a/android_webview/browser/browser_view_renderer.cc b/android_webview/browser/browser_view_renderer.cc

index 7ac57f2d796e73c5cce02d7b935017253903cd2a..1107e30783ca427dda775d2a7c56f4f82a4c3dd2 100644

--- a/android_webview/browser/browser_view_renderer.cc

+++ b/android_webview/browser/browser_view_renderer.cc

@@ -446,10 +446,6 @@ void BrowserViewRenderer::OnDetachedFromWindow() {

// See AwContents::ReleaseHardwareDrawOnRenderThread(JNIEnv*, jobject).

}

-bool BrowserViewRenderer::IsAttachedToWindow() const {

- return attached_to_window_;

bool BrowserViewRenderer::IsVisible() const {

// Ignore |window_visible_| if |attached_to_window_| is false.

return view_visible_ && (!attached_to_window_ || window_visible_);