Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 348563003: Move BookmarkCodec into bookmarks namespace. (Closed)

Created:
6 years, 6 months ago by tfarina
Modified:
6 years, 6 months ago
Reviewers:
sky
CC:
chromium-reviews, tfarina, browser-components-watch_chromium.org, blundell, sdefresne, nshaik
Project:
chromium
Visibility:
Public.

Description

Move BookmarkCodec into bookmarks namespace. BUG=370433 TEST=None R=sky@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278503

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -2 lines) Patch
M chrome/browser/bookmarks/bookmark_html_writer.cc View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_codec.h View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_codec.cc View 2 chunks +4 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_codec_unittest.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M components/bookmarks/browser/bookmark_model.h View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
tfarina
6 years, 6 months ago (2014-06-19 17:49:03 UTC) #1
sky
LGTM
6 years, 6 months ago (2014-06-19 20:18:22 UTC) #2
tfarina
The CQ bit was checked by tfarina@chromium.org
6 years, 6 months ago (2014-06-19 21:38:08 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/348563003/1
6 years, 6 months ago (2014-06-19 21:41:07 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 22:04:36 UTC) #5
Message was sent while issue was closed.
Change committed as 278503

Powered by Google App Engine
This is Rietveld 408576698