Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Issue 348553004: Remove the (now-empty) sent_info field when logging QUIC ack frames. (Closed)

Created:
6 years, 6 months ago by Ryan Hamilton
Modified:
6 years, 6 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, Ian Swett
Project:
chromium
Visibility:
Public.

Description

Remove the (now-empty) sent_info field when logging QUIC ack frames. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M net/quic/quic_connection_logger.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
Ryan Hamilton
rtenneti: please review ianswett: FYI
6 years, 6 months ago (2014-06-19 16:42:22 UTC) #1
ramant (doing other things)
lgtm
6 years, 6 months ago (2014-06-19 17:16:05 UTC) #2
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 6 months ago (2014-06-19 17:22:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/348553004/1
6 years, 6 months ago (2014-06-19 17:24:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-19 21:10:43 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_aosp on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_aosp/builds/85535)
6 years, 6 months ago (2014-06-19 21:10:44 UTC) #6
Ryan Hamilton
The CQ bit was checked by rch@chromium.org
6 years, 6 months ago (2014-06-20 21:08:34 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/rch@chromium.org/348553004/1
6 years, 6 months ago (2014-06-20 21:12:24 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 22:07:27 UTC) #9
Message was sent while issue was closed.
Change committed as 278834

Powered by Google App Engine
This is Rietveld 408576698