Issue 348553003: Simplify GlyphBuffer::reverse.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348553003: Simplify GlyphBuffer::reverse. (Closed)

Created:
6 years, 6 months ago by jbroman

Modified:
6 years, 6 months ago

Reviewers:
leviw_travelin_and_unemployed, esprehn, eae

CC:
blink-reviews, jamesr, krit, jbroman, danakj, Rik, Stephen Chennney, pdr., rwlbuis

Base URL:
svn://svn.chromium.org/blink/trunk

Project:
blink

Visibility:
Public.

Simplify GlyphBuffer::reverse. Since only the entire buffer is ever reversed, a simpler and more obvious implementation using WTF::Vector::reverse is possible. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176526

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -20 lines)			Patch
M	Source/platform/fonts/Font.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
M	Source/platform/fonts/GlyphBuffer.h	View	2 chunks	+4 lines, -18 lines	0 comments	Download
M	Source/platform/fonts/mac/FontComplexTextMac.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

jbroman

Should be trivial. We never reverse anything but the entire buffer, and WTF::Vector already provides ...

6 years, 6 months ago (2014-06-19 15:18:48 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jbroman@chromium.org/348553003/1

6 years, 6 months ago (2014-06-19 16:43:07 UTC) #4

Message was sent while issue was closed.

Change committed as 176526