Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Side by Side Diff: tools/clang/plugins/FindBadConstructsAction.cpp

Issue 348543002: Chrome clang plugin cleanup part 1 of ?? (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Fix fat finger deletion Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
(Empty)
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include "FindBadConstructsAction.h"
6
7 #include "clang/Frontend/FrontendPluginRegistry.h"
8
9 #include "FindBadConstructsConsumer.h"
10
11 using namespace clang;
12
13 namespace chrome_checker {
14
15 FindBadConstructsAction::FindBadConstructsAction() {
16 }
17
18 ASTConsumer* FindBadConstructsAction::CreateASTConsumer(
19 CompilerInstance& instance,
20 llvm::StringRef ref) {
21 return new FindBadConstructsConsumer(instance, options_);
22 }
23
24 bool FindBadConstructsAction::ParseArgs(const CompilerInstance& instance,
25 const std::vector<std::string>& args) {
26 bool parsed = true;
27
28 for (size_t i = 0; i < args.size() && parsed; ++i) {
29 if (args[i] == "skip-virtuals-in-implementations") {
30 // TODO(rsleevi): Remove this once http://crbug.com/115047 is fixed.
31 options_.check_virtuals_in_implementations = false;
32 } else if (args[i] == "check-base-classes") {
33 // TODO(rsleevi): Remove this once http://crbug.com/123295 is fixed.
34 options_.check_base_classes = true;
35 } else if (args[i] == "check-weak-ptr-factory-order") {
36 // TODO(dmichael): Remove this once http://crbug.com/303818 is fixed.
37 options_.check_weak_ptr_factory_order = true;
38 } else if (args[i] == "check-enum-last-value") {
39 // TODO(tsepez): Enable this by default once http://crbug.com/356815
40 // and http://crbug.com/356816 are fixed.
41 options_.check_enum_last_value = true;
42 } else {
43 parsed = false;
44 llvm::errs() << "Unknown clang plugin argument: " << args[i] << "\n";
45 }
46 }
47
48 return parsed;
49 }
50
51 } // namespace chrome_checker
52
53 static FrontendPluginRegistry::Add<chrome_checker::FindBadConstructsAction> X(
54 "find-bad-constructs",
55 "Finds bad C++ constructs");
OLDNEW
« no previous file with comments | « tools/clang/plugins/FindBadConstructsAction.h ('k') | tools/clang/plugins/FindBadConstructsConsumer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698