Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 348543002: Chrome clang plugin cleanup part 1 of ?? (Closed)

Created:
6 years, 6 months ago by dcheng
Modified:
6 years, 6 months ago
Reviewers:
Elliot Glaysher
CC:
chromium-reviews, Nico
Project:
chromium
Visibility:
Public.

Description

Chrome clang plugin cleanup part 1 of ?? The clang plugin has grown organically over its lifetime. This patch just splits apart the options struct, the PluginASTAction (which most developers don't care about), and the actual ASTConsumer into separate units. R=erg@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278487

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : Formatted #

Patch Set 5 : Fix fat finger deletion #

Unified diffs Side-by-side diffs Delta from patch set Stats (+899 lines, -779 lines) Patch
D tools/clang/plugins/FindBadConstructs.cpp View 1 chunk +0 lines, -779 lines 0 comments Download
A tools/clang/plugins/FindBadConstructsAction.h View 1 2 3 4 1 chunk +32 lines, -0 lines 0 comments Download
A tools/clang/plugins/FindBadConstructsAction.cpp View 1 2 3 4 1 chunk +55 lines, -0 lines 0 comments Download
A tools/clang/plugins/FindBadConstructsConsumer.h View 1 2 3 1 chunk +100 lines, -0 lines 0 comments Download
A tools/clang/plugins/FindBadConstructsConsumer.cpp View 1 2 3 1 chunk +687 lines, -0 lines 0 comments Download
A tools/clang/plugins/Options.h View 1 2 3 1 chunk +25 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
dcheng
Hopefully the first step towards splitting the checks apart into well-defined modules...
6 years, 6 months ago (2014-06-19 03:45:57 UTC) #1
dcheng
On 2014/06/19 at 03:45:57, dcheng wrote: > Hopefully the first step towards splitting the checks ...
6 years, 6 months ago (2014-06-19 03:46:34 UTC) #2
Elliot Glaysher
lgtm
6 years, 6 months ago (2014-06-19 17:42:28 UTC) #3
dcheng
6 years, 6 months ago (2014-06-19 21:15:21 UTC) #4
Message was sent while issue was closed.
Committed patchset #5 manually as r278487 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698