Issue 348533004: Remove TestWebContents override that doesn't override anything.

Issue 348533004: Remove TestWebContents override that doesn't override anything. (Closed)

Created:
6 years, 6 months ago by ppi

Modified:
6 years, 6 months ago

Reviewers:
Avi (use Gerrit), nasko

CC:
chromium-reviews, darin-cc_chromium.org, nasko+codewatch_chromium.org, jam, creis+watch_chromium.org, miu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Remove TestWebContents cross-site override that doesn't override anything. ShouldTransitionCrossSite is set to true in WebContents tests but no one ever reads the value, as the authorative method is now in RenderFrameHostManager. This patch removes the broken code. BUG=None R=avi@chromium.org, nasko@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278679

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+0 lines, -25 lines)			Patch
M	content/browser/web_contents/web_contents_impl_unittest.cc	View	15 chunks	+0 lines, -17 lines	0 comments	Download
M	content/test/test_web_contents.h	View	2 chunks	+0 lines, -7 lines	0 comments	Download
M	content/test/test_web_contents.cc	View	1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 7 (0 generated)

ppi

Random discovery, ptal. Should we be worried about this being broken?

6 years, 6 months ago (2014-06-19 17:44:06 UTC) #1

nasko

Since it is never used, it is LGTM to remove it. I tried tracing the ...

6 years, 6 months ago (2014-06-19 22:40:31 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ppi@chromium.org/348533004/1

6 years, 6 months ago (2014-06-20 09:01:35 UTC) #6

ppi

6 years, 6 months ago (2014-06-20 11:52:12 UTC) #7

Message was sent while issue was closed.

Committed patchset #1 manually as r278679 (presubmit successful).