Send backspace to ChromeVox from Braille IME.

Send backspace to ChromeVox from Braille IME.

This makes the backspace key on the qwerty keyboard to behave like
an emulaed backspace key on a braille display when the IME is in braille
keyboard on standard keyboard mode.

BUG=310285
R=dtseng@chromium.org

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278615

[David Tseng, 2014-06-19 21:30:16]

lgtm

https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/braille_ime/braille_ime.js (right):

https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/braille_ime/braille_ime.js:418:
console.log('replaceText: ' + deleteBefore + ',' + toInsert);
nit: Remove

https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs
(right):

https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs:224:
console.log(JSON.stringify(this.port.messages));
nit: remove

https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
File chrome/browser/resources/chromeos/braille_ime/externs.js (right):

https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
chrome/browser/resources/chromeos/braille_ime/externs.js:49: 
lots of whitespace here?

[Peter Lundblad, 2014-06-19 21:40:06]

dtseng@chromium.org writes:
> lgtm
> 
> 
> 
> 
>
https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
> File chrome/browser/resources/chromeos/braille_ime/braille_ime.js
> (right):
> 
>
https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/braille_ime/braille_ime.js:418:
> console.log('replaceText: ' + deleteBefore + ',' + toInsert);
> nit: Remove

I seriously need my on presubmit script for this, thanks!

>
https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
> File
> chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs
> (right):
> 
>
https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
>
chrome/browser/resources/chromeos/braille_ime/braille_ime_unittest.gtestjs:224:
> console.log(JSON.stringify(this.port.messages));
> nit: remove

Done.

>
https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
> File chrome/browser/resources/chromeos/braille_ime/externs.js (right):
> 
>
https://codereview.chromium.org/348533003/diff/1/chrome/browser/resources/chr...
> chrome/browser/resources/chromeos/braille_ime/externs.js:49:
> lots of whitespace here?

Trimmed.

> https://codereview.chromium.org/348533003/

-- 

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Peter Lundblad, 2014-06-19 21:40:48]

The CQ bit was checked by plundblad@chromium.org

[commit-bot: I haz the power, 2014-06-19 21:43:51]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/plundblad@chromium.org/348533003/20001

[commit-bot: I haz the power, 2014-06-20 03:22:32]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-20 05:24:42]

Change committed as 278615