Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(117)

Issue 348523005: Revert of cc: Early out sooner in UpdateTilePriorities when !CanHaveTilings(). (Closed)

Created:
6 years, 6 months ago by jackhou1
Modified:
6 years, 6 months ago
Reviewers:
danakj, enne (OOO)
CC:
cc-bugs_chromium.org, chromium-reviews, piman
Project:
chromium
Visibility:
Public.

Description

Revert of cc: Early out sooner in UpdateTilePriorities when !CanHaveTilings(). (https://codereview.chromium.org/334953003/) Reason for revert: This appears to have broken: CreateTilingsEvenIfTwinHasNone ManageTilingsWithNoRecording http://build.chromium.org/p/chromium.mac/waterfall?builder=Mac%2010.7%20Tests%20(dbg)(1) http://build.chromium.org/p/chromium.win/waterfall?builder=Win7%20Tests%20(dbg)(1) http://build.chromium.org/p/chromium.linux/builders/Linux%20Tests%20%28dbg%29%282%29%2832%29/builds/13876 Original issue's description: > cc: Early out sooner in UpdateTilePriorities when !CanHaveTilings(). > > Also, when we cleanup tilings on the active twin, we use the pending > twin's ideal contents scale. But when the twin !CanHavTilings() there > is no need to use that ideal scale and save tilings. > > R=enne@chromium.org, enne > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278219 TBR=enne@chromium.org,danakj@chromium.org NOTREECHECKS=true NOTRY=true Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278262

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+73 lines, -64 lines) Patch
M cc/layers/picture_layer_impl.cc View 3 chunks +17 lines, -19 lines 0 comments Download
M cc/layers/picture_layer_impl_unittest.cc View 1 chunk +0 lines, -45 lines 0 comments Download
M cc/trees/layer_tree_host_impl_unittest.cc View 1 chunk +56 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
jackhou1
Created Revert of cc: Early out sooner in UpdateTilePriorities when !CanHaveTilings().
6 years, 6 months ago (2014-06-19 03:59:31 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/348523005/1
6 years, 6 months ago (2014-06-19 04:02:30 UTC) #2
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 04:05:20 UTC) #3
Message was sent while issue was closed.
Change committed as 278262

Powered by Google App Engine
This is Rietveld 408576698