On Windows ASH ensure that we get the display created for the root window serving ASH.

On Windows ASH ensure that we get the display created for the root window serving ASH.

This ensures that windows created in ASH honor the shell work area etc.

We have bugs today where in the first maximized window in ASH does not honor the work area
leading to problems.

Changes as below:-
1. Added a function IsAshProcess for Windows in ash_init.cc. This returns true if the browser
   is launched to serve ASH.
2. In the DefaultTargetDisplayProvider::GetTargetDisplay function check if the browser is launched
   for ASH along with the check for whether ASH is to be opened on startup. If yes then we get the
   display for the root window created for ASH.

BUG=361776
R=sky

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278534

[sky, 2014-06-19 15:36:00]

https://codereview.chromium.org/348513002/diff/1/chrome/browser/ui/ash/ash_in...
File chrome/browser/ui/ash/ash_init.h (right):

https://codereview.chromium.org/348513002/diff/1/chrome/browser/ui/ash/ash_in...
chrome/browser/ui/ash/ash_init.h:24: bool IsAshProcess();
This name is confusing and implies we have a separate process that ash lives in,
which isn't the case. Maybe IsViewerProcess? Also, if you only need this in
window_sizer, how about moving there? Ideally the code you're changing would
exist only in window_sizer_ash.

[ananta, 2014-06-19 19:30:25]

https://codereview.chromium.org/348513002/diff/1/chrome/browser/ui/ash/ash_in...
File chrome/browser/ui/ash/ash_init.h (right):

https://codereview.chromium.org/348513002/diff/1/chrome/browser/ui/ash/ash_in...
chrome/browser/ui/ash/ash_init.h:24: bool IsAshProcess();
On 2014/06/19 15:36:00, sky wrote:
> This name is confusing and implies we have a separate process that ash lives
in,
> which isn't the case. Maybe IsViewerProcess? Also, if you only need this in
> window_sizer, how about moving there? Ideally the code you're changing would
> exist only in window_sizer_ash.

IsViewerProcess does not seem right. Viewer is the process which runs on the
other side for Windows ASH. 

In any case, removed this function and replaced the call in window_sizer.cc with
a check for the switch there.

We can add a function for the same if we need similar functionality elsewhere
later.

[sky, 2014-06-19 20:27:23]

LGTM

[ananta, 2014-06-19 21:28:38]

The CQ bit was checked by ananta@chromium.org

[commit-bot: I haz the power, 2014-06-19 21:30:21]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ananta@chromium.org/348513002/20001

[commit-bot: I haz the power, 2014-06-19 23:53:04]

Change committed as 278534