Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(712)

Unified Diff: content/child/webcrypto/platform_crypto_nss.cc

Issue 348493005: Revert of [webcrypto] Give more descriptive error messages on Linux for unsupported functionality. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | content/child/webcrypto/status.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/child/webcrypto/platform_crypto_nss.cc
diff --git a/content/child/webcrypto/platform_crypto_nss.cc b/content/child/webcrypto/platform_crypto_nss.cc
index e8a0237a7d79088cde466e70a8f7b40935df7b7b..11c84fc87bbf17018f9c7f58fb0e8646827a4798 100644
--- a/content/child/webcrypto/platform_crypto_nss.cc
+++ b/content/child/webcrypto/platform_crypto_nss.cc
@@ -277,21 +277,6 @@
namespace {
-Status NssSupportsAesGcm() {
- if (g_nss_runtime_support.Get().IsAesGcmSupported())
- return Status::Success();
- return Status::ErrorUnsupported(
- "NSS version doesn't support AES-GCM. Try using version 3.15 or later");
-}
-
-Status NssSupportsRsaOaep() {
- if (g_nss_runtime_support.Get().IsRsaOaepSupported())
- return Status::Success();
- return Status::ErrorUnsupported(
- "NSS version doesn't support RSA-OAEP. Try using version 3.16.2 or "
- "later");
-}
-
// Creates a SECItem for the data in |buffer|. This does NOT make a copy, so
// |buffer| should outlive the SECItem.
SECItem MakeSECItemForBuffer(const CryptoData& buffer) {
@@ -463,9 +448,8 @@
const CryptoData& additional_data,
unsigned int tag_length_bits,
std::vector<uint8>* buffer) {
- Status status = NssSupportsAesGcm();
- if (status.IsError())
- return status;
+ if (!g_nss_runtime_support.Get().IsAesGcmSupported())
+ return Status::ErrorUnsupported();
unsigned int tag_length_bytes = tag_length_bits / 8;
@@ -613,9 +597,8 @@
return Status::Success();
}
case blink::WebCryptoAlgorithmIdAesGcm: {
- Status status = NssSupportsAesGcm();
- if (status.IsError())
- return status;
+ if (!g_nss_runtime_support.Get().IsAesGcmSupported())
+ return Status::ErrorUnsupported();
*mechanism = CKM_AES_GCM;
*flags = CKF_ENCRYPT | CKF_DECRYPT;
return Status::Success();
@@ -1254,9 +1237,8 @@
const CryptoData& label,
const CryptoData& data,
std::vector<uint8>* buffer) {
- Status status = NssSupportsRsaOaep();
- if (status.IsError())
- return status;
+ if (!g_nss_runtime_support.Get().IsRsaOaepSupported())
+ return Status::ErrorUnsupported();
CK_RSA_PKCS_OAEP_PARAMS oaep_params = {0};
if (!InitializeRsaOaepParams(hash, label, &oaep_params))
@@ -1292,9 +1274,8 @@
const CryptoData& label,
const CryptoData& data,
std::vector<uint8>* buffer) {
- Status status = NssSupportsRsaOaep();
- if (status.IsError())
- return status;
+ if (!g_nss_runtime_support.Get().IsRsaOaepSupported())
+ return Status::ErrorUnsupported();
CK_RSA_PKCS_OAEP_PARAMS oaep_params = {0};
if (!InitializeRsaOaepParams(hash, label, &oaep_params))
@@ -1442,10 +1423,9 @@
unsigned long public_exponent,
blink::WebCryptoKey* public_key,
blink::WebCryptoKey* private_key) {
- if (algorithm.id() == blink::WebCryptoAlgorithmIdRsaOaep) {
- Status status = NssSupportsRsaOaep();
- if (status.IsError())
- return status;
+ if (algorithm.id() == blink::WebCryptoAlgorithmIdRsaOaep &&
+ !g_nss_runtime_support.Get().IsRsaOaepSupported()) {
+ return Status::ErrorUnsupported();
}
crypto::ScopedPK11Slot slot(PK11_GetInternalKeySlot());
« no previous file with comments | « no previous file | content/child/webcrypto/status.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698