Issue 348493005: Revert of [webcrypto] Give more descriptive error messages on Linux for unsupported functionality.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348493005: Revert of [webcrypto] Give more descriptive error messages on Linux for unsupported functionality. (Closed)

Created:
6 years, 6 months ago by jackhou1

Modified:
6 years, 6 months ago

Reviewers:
eroman, Ryan Sleevi

CC:
chromium-reviews, darin-cc_chromium.org, jam

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Revert of [webcrypto] Give more descriptive error messages on Linux for unsupported functionality. (https://codereview.chromium.org/343473004/) Reason for revert: This broke SharedCryptoTest: http://build.chromium.org/p/chromium.linux/builders/Linux%20Clang%20%28dbg%29/builds/61059 Original issue's description: > [webcrypto] Give more descriptive error messages on Linux for unsupported functionality. > > * If NSS version doesn't support AES-GCM > * If NSS version doesn't support RSA-OAEP > > BUG=384485 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278230 TBR=rsleevi@chromium.org,eroman@chromium.org NOTREECHECKS=true NOTRY=true BUG=384485 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278258

Created: 6 years, 6 months ago

(Patch set is too large to download)

	Unified diffs	Side-by-side diffs	Stats (+13 lines, -37 lines)			Patch
M	content/child/webcrypto/platform_crypto_nss.cc	View	6 chunks	+11 lines, -31 lines	0 comments	Download
M	content/child/webcrypto/status.h	View	1 chunk	+0 lines, -1 line	0 comments	Download
M	content/child/webcrypto/status.cc	View	1 chunk	+2 lines, -5 lines	0 comments	Download

Total messages: 3 (0 generated)

jackhou1

Created Revert of [webcrypto] Give more descriptive error messages on Linux for unsupported functionality.

6 years, 6 months ago (2014-06-19 03:47:05 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jackhou@chromium.org/348493005/1

6 years, 6 months ago (2014-06-19 03:47:44 UTC) #2

Message was sent while issue was closed.

Change committed as 278258