Added support for git cl upload automatic trybot determination.

Added support for git cl upload automatic trybot determination.

This is part of my intern project, which is detailed here:
  "https://docs.google.com/a/google.com/document/d/10bkzag1UUbtESPkEWHYaZtGMEEbCN5Zad72PuoRpwZE/edit#"

The idea is to have "git cl upload" annotate the CL description with a
flag like "CQ_TRYBOTS=...", which CQ will then look at to determine which
trybots to run the the given CL.

The CL for the change for CQ is at "https://chromereviews.googleplex.com/51757013/".

R=dpranke@google.com, iannucci@google.com
BUG=378097
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=280039

[martiniss, 2014-06-18 22:53:00]

Hi,

This CL modifies "git cl upload" to add a new flag "--auto-bots", which causes a
list of trybots generated from PRESUBMIT.py to be uploaded to Rietveld in the
description. This list is read by CQ to determine which trybots to run the given
CL on. 

Here's a design document describing this project:
https://docs.google.com/a/google.com/document/d/10bkzag1UUbtESPkEWHYaZtGMEEbC...

Let me know if I need to change anything, especially the tests. 

Stephen

[iannucci, 2014-06-24 23:24:00]

looks generally good, just a few nits

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py#newcode1582
git_cl.py:1582: if options.auto_bots: #dpranke, iannucci
do not want the comment :)

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py#newcode1591
git_cl.py:1591: )
paren should wrap up here

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py#newcode1594
git_cl.py:1594: change_description = change_desc.description + '\n\nCQ_TRYBOTS='
I think you only want one newline here

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py#newcode1596
git_cl.py:1596: change_description += master + ':' + ','.join(mapping.keys()) +
';'
I think you'll want to do a ';'.join of these lines

https://chromiumcodereview.appspot.com/348473003/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://chromiumcodereview.appspot.com/348473003/diff/1/tests/git_cl_test.py#...
tests/git_cl_test.py:815: return lambda x: True
these should be methods :D

[martiniss, 2014-06-24 23:55:56]

Fixed nits. Also, I listed out the mocked out functions.

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py
File git_cl.py (right):

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py#newcode1582
git_cl.py:1582: if options.auto_bots: #dpranke, iannucci
On 2014/06/24 23:23:59, iannucci wrote:
> do not want the comment :)

Done.

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py#newcode1591
git_cl.py:1591: )
On 2014/06/24 23:23:59, iannucci wrote:
> paren should wrap up here

Done.

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py#newcode1594
git_cl.py:1594: change_description = change_desc.description + '\n\nCQ_TRYBOTS='
On 2014/06/24 23:23:59, iannucci wrote:
> I think you only want one newline here

Done.

https://chromiumcodereview.appspot.com/348473003/diff/1/git_cl.py#newcode1596
git_cl.py:1596: change_description += master + ':' + ','.join(mapping.keys()) +
';'
On 2014/06/24 23:23:59, iannucci wrote:
> I think you'll want to do a ';'.join of these lines

Done.

https://chromiumcodereview.appspot.com/348473003/diff/1/tests/git_cl_test.py
File tests/git_cl_test.py (right):

https://chromiumcodereview.appspot.com/348473003/diff/1/tests/git_cl_test.py#...
tests/git_cl_test.py:815: return lambda x: True
On 2014/06/24 23:23:59, iannucci wrote:
> these should be methods :D

Done! Manually added all the mocked methods.

[iannucci, 2014-06-26 17:22:23]

lgtm

https://codereview.chromium.org/348473003/diff/20001/git_cl.py
File git_cl.py (right):

https://codereview.chromium.org/348473003/diff/20001/git_cl.py#newcode1728
git_cl.py:1728: parser.add_option('--auto-bots', default=False,
action='store_true',
auto-bots, roll out?

[martiniss, 2014-06-26 17:26:14]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2014-06-26 17:27:27]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/martiniss@chromium.org/348473003/20001

[commit-bot: I haz the power, 2014-06-26 17:29:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-06-26 17:29:05]

Presubmit check for 348473003-20001 failed and returned exit status 1.

Running presubmit commit checks ...
Checking out rietveld...
Running save-description-on-failure.sh
Running push-basic.sh
Running upstream.sh
Running submit-from-new-dir.sh
Running abandon.sh
Running submodule-merge-test.sh
Running upload-local-tracking-branch.sh
Running hooks.sh
Running post-dcommit-hook-test.sh
Running upload-stale.sh
Running patch.sh
Running basic.sh

** Presubmit ERRORS **
Pylint (97 files) (30.46s) failed
************* Module
/b/infra_internal/commit_queue/workdir/tools/depot_tools/tests/git_cl_test.py
R0201:812,2:ChangelistMock.GetIssue: Method could be a function
R0201:815,2:ChangelistMock.GetBranch: Method could be a function
R0201:818,2:ChangelistMock.GetCommonAncestorWithUpstream: Method could be a
function
R0201:821,2:ChangelistMock.GetCCList: Method could be a function
R0201:824,2:ChangelistMock.GetGitBaseUrlFromConfig: Method could be a function
R0201:827,2:ChangelistMock.GetRemoteUrl: Method could be a function
R0201:830,2:ChangelistMock.GetRietveldServer: Method could be a function
R0201:850,2:ChangeMock.FullDescriptionText: Method could be a function
R0201:853,2:ChangeMock.RepositoryRoot: Method could be a function
R0201:856,2:ChangeMock.AffectedFiles: Method could be a function
R0201:859,2:ChangeMock.LocalPaths: Method could be a function


Presubmit checks took 94.3s to calculate.

Was the presubmit check useful? If not, run "git cl presubmit -v"
to figure out which PRESUBMIT.py was run, then run git blame
on the file to figure out who to ask for help.

[martiniss, 2014-06-26 17:34:44]

The CQ bit was checked by martiniss@chromium.org

[commit-bot: I haz the power, 2014-06-26 17:35:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/martiniss@chromium.org/348473003/40001

[commit-bot: I haz the power, 2014-06-26 17:38:40]

Change committed as 280039