Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(124)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 348443002: Revert 274823 "Support for audio output devices for getMediaDevi..." (Closed)

Created:
6 years, 6 months ago by amineer_google
Modified:
6 years, 6 months ago
Reviewers:
Henrik Grunell
CC:
chromium-reviews, jam, mcasas+watch_chromium.org, feature-media-reviews_chromium.org, darin-cc_chromium.org, wjia+watch_chromium.org, miu+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Revert 274823 "Support for audio output devices for getMediaDevi..." Reverting this change to revert 274608 to evaluate if flash crashes disappear per bug findings > Support for audio output devices for getMediaDevices. > > * This CL depends on https://codereview.chromium.org/287383002/ > * There's no caching or monitoring in this CL. > * Browser test will be done in follow-up CL. (That's pending blink interface landing.) > > BUG=338511 > > Review URL: https://codereview.chromium.org/312773002 TBR=grunell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278172

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+70 lines, -262 lines) Patch
M chrome/browser/media/media_stream_capture_indicator.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host.cc View 1 chunk +4 lines, -6 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_dispatcher_host_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.h View 2 chunks +1 line, -7 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_manager.cc View 14 chunks +11 lines, -81 lines 0 comments Download
M content/browser/renderer_host/media/media_stream_ui_proxy.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M content/public/common/media_stream_request.h View 3 chunks +2 lines, -7 lines 0 comments Download
M content/public/common/media_stream_request.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_dispatcher.cc View 3 chunks +3 lines, -4 lines 0 comments Download
M content/renderer/media/media_stream_dispatcher_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M content/renderer/media/media_stream_impl.cc View 9 chunks +18 lines, -66 lines 0 comments Download
M content/renderer/media/media_stream_impl_unittest.cc View 2 chunks +5 lines, -31 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.h View 3 chunks +6 lines, -15 lines 0 comments Download
M content/renderer/media/mock_media_stream_dispatcher.cc View 6 chunks +13 lines, -38 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
amineer_google
6 years, 6 months ago (2014-06-18 20:59:22 UTC) #1
amineer_google
Committed patchset #1 manually as r278172.
6 years, 6 months ago (2014-06-18 21:00:25 UTC) #2
Henrik Grunell
6 years, 6 months ago (2014-06-23 08:51:06 UTC) #3
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698