remoting/android/java/src/org/chromium/chromoting/HostListLoader.java - Issue 348433002: Verify the host-supplied URL matches the domain's allowed URL patterns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: remoting/android/java/src/org/chromium/chromoting/HostListLoader.java

Issue 348433002: Verify the host-supplied URL matches the domain's allowed URL patterns (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« remoting/android/java/src/org/chromium/chromoting/HostInfo.java ('K') | « remoting/android/java/src/org/chromium/chromoting/HostInfo.java ('k') | remoting/android/java/src/org/chromium/chromoting/ThirdPartyTokenFetcher.java » ('j') | remoting/android/java/src/org/chromium/chromoting/ThirdPartyTokenFetcher.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: remoting/android/java/src/org/chromium/chromoting/HostListLoader.java

diff --git a/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java b/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java

index 8f3b6bd257fd149c5ab6e75b6915db4374ff94ea..bfcdfd8adac22dac6e0870222cb4a277ae9d73e8 100644

--- a/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java

+++ b/remoting/android/java/src/org/chromium/chromoting/HostListLoader.java

@@ -145,12 +145,7 @@ public class HostListLoader {

// attempt will fail because of the missing keys. The failed attempt will

// trigger reloading of the host-list, by which time the keys will hopefully be

// present, and the retried connection can succeed.

- HostInfo host = new HostInfo(

- hostJson.getString("hostName"),

- hostJson.getString("hostId"),

- hostJson.optString("jabberId"),

- hostJson.optString("publicKey"),

- hostJson.optString("status").equals("ONLINE"));

+ HostInfo host = HostInfo.create(hostJson);

hostList.add(host);

++index;

}