Issue 348403003: Reverting 267374 on 36 branch.

Issue 348403003: Reverting 267374 on 36 branch. (Closed)

Created:
6 years, 6 months ago by matthewyuan

Modified:
6 years, 6 months ago

Reviewers:
Roger Tawa OOO till Jul 10th

CC:
chromium-reviews, tim+watch_chromium.org, nkostylev+watch_chromium.org, haitaol+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org, maniscalco+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/branches/1985/src/

Visibility:
Public.

More Reviews

Description

Reverting 267374 on 36 branch. Revert 267374 "Use new people.get api instead of oauth2/v1/useri..." > Use new people.get api instead of oauth2/v1/userinfo. > Consolidate all uses into main helper class. > > Details about new api: https://developers.google.com/+/api/latest/people/get > > Format of returned response: https://developers.google.com/+/api/latest/people#resource > > BUG=320354 > > Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267068 > > Review URL: https://codereview.chromium.org/257773002 TBR=rogerta@chromium.org BUG=387707 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=280061

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+215 lines, -289 lines)			Patch
M	chrome/browser/chromeos/login/user_image_manager_browsertest.cc	View	2 chunks	+3 lines, -6 lines	0 comments	Download
M	chrome/browser/chromeos/policy/policy_oauth2_token_fetcher.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download
M	chrome/browser/chromeos/policy/wildcard_login_checker.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/policy/cloud/user_policy_signin_service_unittest.cc	View	4 chunks	+3 lines, -10 lines	0 comments	Download
M	chrome/browser/profiles/profile_downloader.h	View	5 chunks	+3 lines, -11 lines	0 comments	Download
M	chrome/browser/profiles/profile_downloader.cc	View	6 chunks	+69 lines, -51 lines	0 comments	Download
M	chrome/browser/profiles/profile_downloader_unittest.cc	View	2 chunks	+25 lines, -20 lines	0 comments	Download
M	chrome/browser/signin/account_reconcilor_unittest.cc	View	10 chunks	+10 lines, -10 lines	0 comments	Download
M	chrome/browser/sync/test/integration/sync_test.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/webui/local_discovery/local_discovery_ui_browsertest.cc	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	components/policy/core/common/cloud/cloud_policy_client_registration_helper.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	components/policy/core/common/cloud/user_info_fetcher.h	View	3 chunks	+7 lines, -20 lines	0 comments	Download
M	components/policy/core/common/cloud/user_info_fetcher.cc	View	2 chunks	+53 lines, -20 lines	0 comments	Download
M	components/policy/core/common/cloud/user_info_fetcher_unittest.cc	View	4 chunks	+4 lines, -7 lines	0 comments	Download
M	google_apis/gaia/gaia_constants.h	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	google_apis/gaia/gaia_constants.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	google_apis/gaia/gaia_oauth_client.h	View	3 chunks	+3 lines, -15 lines	0 comments	Download
M	google_apis/gaia/gaia_oauth_client.cc	View	7 chunks	+9 lines, -51 lines	0 comments	Download
M	google_apis/gaia/gaia_oauth_client_unittest.cc	View	3 chunks	+14 lines, -45 lines	0 comments	Download
M	google_apis/gaia/gaia_urls.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	google_apis/gaia/gaia_urls.cc	View	3 chunks	+5 lines, -5 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

matthewyuan

6 years, 6 months ago (2014-06-26 18:47:40 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 manually as r280061 (tree was closed).

Expand Messages | Collapse Messages