Issue 348363002: Add chrome/plugin and chrome/utility to GN build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348363002: Add chrome/plugin and chrome/utility to GN build. (Closed)

Created:
6 years, 6 months ago by brettw

Modified:
6 years, 6 months ago

Reviewers:
jamesr

CC:
chromium-reviews, kalyank, Ian Vollick, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, stuartmorgan+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, danakj+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Add chrome/plugin and chrome/utility to GN build. Updates some TODO references to blink now that there's a proper blink target. R=jamesr@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279202

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+214 lines, -92 lines)			Patch
M	BUILD.gn	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	chrome/chrome_utility.gypi	View	5 chunks	+93 lines, -78 lines	0 comments	Download
A	chrome/plugin/BUILD.gn	View	1 chunk	+18 lines, -0 lines	0 comments	Download
A	chrome/utility/BUILD.gn	View	1 chunk	+89 lines, -0 lines	0 comments	Download
M	content/child/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	content/plugin/BUILD.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/ppapi_plugin/BUILD.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	content/worker/BUILD.gn	View	1 chunk	+1 line, -3 lines	0 comments	Download
M	ui/compositor/BUILD.gn	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	webkit/child/BUILD.gn	View	1 chunk	+1 line, -1 line	0 comments	Download
M	webkit/common/gpu/BUILD.gn	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	webkit/common/gpu/webkit_gpu.gyp	View	1 chunk	+1 line, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Message was sent while issue was closed.

Committed patchset #1 manually as r279202.

Expand Messages | Collapse Messages