Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(166)

Issue 348343002: add pathops tight bounds; conform path ops' gyp to unit tests (Closed)

Created:
6 years, 6 months ago by caryclark
Modified:
6 years, 6 months ago
Reviewers:
mtklein, bsalomon
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

add pathops tight bounds; conform path ops' gyp to unit tests Implement path tight bounds using path ops machinery. This is not as efficient as it could be; for instance, internally, it creates a path ops structure more suited to intersection. If this shows up as a performance bottleneck, it could be improved. Fix path ops gyp files, which have fallen out of sync with other tests. TBR=mtklein BUG=skia:1712 Committed: https://skia.googlesource.com/skia/+/a8d2ffb1c2e245ae06bdd1c20f34995ab8311cf6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+195 lines, -17 lines) Patch
M gyp/core.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/pathops_unittest.gyp View 2 chunks +11 lines, -17 lines 0 comments Download
M gyp/pathops_unittest.gypi View 2 chunks +18 lines, -0 lines 0 comments Download
M include/pathops/SkPathOps.h View 2 chunks +9 lines, -0 lines 0 comments Download
A src/pathops/SkPathOpsTightBounds.cpp View 1 chunk +33 lines, -0 lines 0 comments Download
A tests/PathOpsTightBoundsTest.cpp View 1 chunk +123 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (0 generated)
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 6 months ago (2014-06-23 15:53:15 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/348343002/1
6 years, 6 months ago (2014-06-23 15:53:22 UTC) #2
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 15:53:26 UTC) #3
commit-bot: I haz the power
Presubmit check for 348343002-1 failed and returned exit status 1. Running presubmit commit checks ...
6 years, 6 months ago (2014-06-23 15:53:27 UTC) #4
caryclark
Brian, please review for the public api change
6 years, 6 months ago (2014-06-23 15:54:51 UTC) #5
bsalomon
lgtm
6 years, 6 months ago (2014-06-24 13:19:35 UTC) #6
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 6 months ago (2014-06-24 14:40:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/348343002/1
6 years, 6 months ago (2014-06-24 14:40:39 UTC) #8
commit-bot: I haz the power
6 years, 6 months ago (2014-06-24 14:55:16 UTC) #9
Message was sent while issue was closed.
Change committed as a8d2ffb1c2e245ae06bdd1c20f34995ab8311cf6

Powered by Google App Engine
This is Rietveld 408576698