Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 348323003: use platform-independent font for gm (Closed)

Created:
6 years, 6 months ago by caryclark
Modified:
6 years, 6 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

use platform-independent font for gm Create a custom typeface and scaler to render simple paths the same on all platforms. GM tests are modified to explicitly select the custom typeface. TBR=reed Committed: https://skia.googlesource.com/skia/+/5fb6bd4b7e8d00b7f2543ca10ec9022b32632f29

Patch Set 1 #

Patch Set 2 : remove include guard #

Patch Set 3 : add include tools for skimage #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3400 lines, -4 lines) Patch
M gm/arithmode.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/bitmapcopy.cpp View 1 chunk +2 lines, -0 lines 0 comments Download
M gm/bitmapfilters.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/bitmapscroll.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/bitmapsource.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/blurs.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/complexclip.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/convexpolyclip.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/cubicpaths.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M gm/degeneratesegments.cpp View 2 chunks +2 lines, -0 lines 0 comments Download
M gm/displacement.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M gm/gm.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M gyp/dm.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/gm.gyp View 1 chunk +1 line, -0 lines 0 comments Download
M gyp/tools.gyp View 1 2 4 chunks +20 lines, -1 line 0 comments Download
M gyp/utils.gypi View 1 chunk +2 lines, -0 lines 0 comments Download
M samplecode/SampleApp.cpp View 2 chunks +8 lines, -0 lines 0 comments Download
A src/fonts/SkTestScalerContext.h View 1 chunk +20 lines, -0 lines 0 comments Download
A src/fonts/SkTestScalerContext.cpp View 1 chunk +250 lines, -0 lines 0 comments Download
A tools/create_test_font.cpp View 1 chunk +169 lines, -0 lines 0 comments Download
M tools/sk_tool_utils.h View 1 chunk +11 lines, -3 lines 0 comments Download
M tools/sk_tool_utils.cpp View 2 chunks +11 lines, -0 lines 0 comments Download
A tools/sk_tool_utils_font.cpp View 1 chunk +2892 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
caryclark
This is essentially the same as before, but conflicts with changes to other gyp files ...
6 years, 6 months ago (2014-06-23 16:45:40 UTC) #1
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 6 months ago (2014-06-23 17:33:12 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/348323003/20001
6 years, 6 months ago (2014-06-23 17:33:48 UTC) #3
mtklein
lgtm
6 years, 6 months ago (2014-06-23 17:37:44 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: Build-Mac10.8-Clang-x86-Release-Trybot on tryserver.skia ...
6 years, 6 months ago (2014-06-23 18:00:29 UTC) #5
caryclark
The CQ bit was checked by caryclark@google.com
6 years, 6 months ago (2014-06-23 18:02:50 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/caryclark@google.com/348323003/40001
6 years, 6 months ago (2014-06-23 18:03:48 UTC) #7
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 18:25:05 UTC) #8
Message was sent while issue was closed. 
Change committed as 5fb6bd4b7e8d00b7f2543ca10ec9022b32632f29

Powered by Google App Engine
This is Rietveld 408576698