Use base::File for the OpenResourceCallback's argument.

Use base::File for the OpenResourceCallback's argument.

ManifestServiceChannel can be removed while the DownloadFile is running.
In such a case, ManifestServiceProxy::DidDownloadFile is called upon
the completion of DownloadFile, and then callback is invoked.
However, as the callback refers the ManifestServiceChannel weakly, so
the native file descriptor will be leaked.
By this change, OpenResourceCallback takes the base::File instead of
base::PlatformFile. Since base::File will take the ownership of the
native file descriptor, it will be closed correctly, even if the
ManifestServiceChannel is deleted before.

BUG=239656
TEST=Ran browser_tests --gtest_filter=*NonSfi*:*NonSFI* locally and trybots.
CQ_EXTRA_TRYBOTS=tryserver.chromium:linux_rel_precise32

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279146

[hidehiko, 2014-06-23 14:54:37]

Hi Justin,

I found there still remains a path that FD would be leaked even after your
r278859 for non-SFI mode.

The scenario is:
- DownloadFile is started by OpenResource().
- before completion, ManifestServiceChannel is removed.
- Upon completion of the DownloadFile, DidDownloadFile is called with (valid)
FD, and then run |callback|.
- Here, as ManifestServiceChannel is already deleted, callback does nothing
(i.e. no-close operation for the FD).

This is a quick fix CL. Could you kindly take a look?

Thanks,
- hidehiko

[teravest, 2014-06-23 15:07:02]

lgtm

[hidehiko, 2014-06-23 18:03:44]

The CQ bit was checked by hidehiko@chromium.org

[commit-bot: I haz the power, 2014-06-23 18:05:15]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/hidehiko@chromium.org/348323002/1

[commit-bot: I haz the power, 2014-06-23 18:24:51]

Change committed as 279146