Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1486)

Unified Diff: chrome/browser/ui/webui/extensions/extension_settings_handler.cc

Issue 348313003: Create withheld permissions (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/extensions/extension_settings_handler.cc
diff --git a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
index 1a14db7c8bf9934f6234fac1b787ad0c84231cbe..25730c04b044a29d638197dd0b4a91b6212cd34b 100644
--- a/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
+++ b/chrome/browser/ui/webui/extensions/extension_settings_handler.cc
@@ -262,10 +262,7 @@ base::DictionaryValue* ExtensionSettingsHandler::CreateExtensionDetailValue(
// - The feature is enabled.
// - The extension has access to enough urls that we can't just let it run
// on those specified in the permissions.
- bool wants_all_urls =
- FeatureSwitch::scripts_require_action()->IsEnabled() &&
- extension->permissions_data()->RequiresActionForScriptExecution(
- extension);
+ bool wants_all_urls = extension->permissions_data()->HasWithheldAllHosts();
extension_data->SetBoolean("wantsAllUrls", wants_all_urls);
extension_data->SetBoolean(
"allowAllUrls",

Powered by Google App Engine
This is Rietveld 408576698