Issue 348283002: [Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348283002: [Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault (Closed)

Created:
6 years, 6 months ago by jeremy

Modified:
6 years, 6 months ago

Reviewers:
Mark Mentovai, awong

CC:
chromium-reviews, glider+watch_chromium.org, erikwright+watch_chromium.org, sadrul, timurrrr+watch_chromium.org, bruening+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

[Mac] Reland r276808 Use a native MessagePump instead of a MessagePumpDefault Original CL: https://codereview.chromium.org/331513002/ Relanding after fixing XmppConnectionTest.MultipleConnect test. BUG=356804, 385604 TBR=mark@chromium.org,ajwong@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279089

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+99 lines, -50 lines)			Patch
M	base/message_loop/message_loop.cc	View	2 chunks	+9 lines, -1 line	0 comments	Download
M	base/message_loop/message_pump_default.h	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	jingle/glue/chrome_async_socket_unittest.cc	View	26 chunks	+48 lines, -39 lines	0 comments	Download
M	jingle/notifier/base/xmpp_connection_unittest.cc	View	6 chunks	+14 lines, -9 lines	0 comments	Download
M	tools/valgrind/memcheck/suppressions_mac.txt	View	2 chunks	+26 lines, -0 lines	0 comments	Download

Total messages: 3 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jeremy@chromium.org/348283002/1

6 years, 6 months ago (2014-06-23 06:54:03 UTC) #2

Message was sent while issue was closed.

Change committed as 279089