Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Issue 348253003: Remove unused functions in PositionOptions (Closed)

Created:
6 years, 6 months ago by kihong
Modified:
6 years, 6 months ago
CC:
blink-reviews, mvanouwerkerk+watch_chromium.org, timvolodine
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

Remove unused functions in PositionOptions setEnableHighAccuracy, setTimeout and setMaximumAge are only used in "V8GeolocationCustom.cpp", but that file has been removed on the r176719. Therefore those functinos have to be removed also. BUG=385426 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=176744

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -17 lines) Patch
M Source/modules/geolocation/PositionOptions.h View 1 chunk +2 lines, -17 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
kihong
PTAL
6 years, 6 months ago (2014-06-23 05:47:00 UTC) #1
haraken
LGTM
6 years, 6 months ago (2014-06-23 06:03:03 UTC) #2
kihong
The CQ bit was checked by kihong.kwon@samsung.com
6 years, 6 months ago (2014-06-23 06:05:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/348253003/1
6 years, 6 months ago (2014-06-23 06:06:50 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-23 08:31:08 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 6 months ago (2014-06-23 09:10:50 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/13091)
6 years, 6 months ago (2014-06-23 09:10:51 UTC) #7
kihong
The CQ bit was checked by kihong.kwon@samsung.com
6 years, 6 months ago (2014-06-23 09:59:41 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kihong.kwon@samsung.com/348253003/1
6 years, 6 months ago (2014-06-23 10:00:39 UTC) #9
Michael van Ouwerkerk
lgtm
6 years, 6 months ago (2014-06-23 10:40:59 UTC) #10
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_blink_rel on tryserver.blink ...
6 years, 6 months ago (2014-06-23 11:02:47 UTC) #11
commit-bot: I haz the power
6 years, 6 months ago (2014-06-23 12:22:36 UTC) #12
Message was sent while issue was closed.
Change committed as 176744

Powered by Google App Engine
This is Rietveld 408576698