Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1830)

Unified Diff: Source/web/WebPluginContainerImpl.cpp

Issue 348193002: Remove some dead scrolling paths and unused params (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/web/WebPluginContainerImpl.cpp
diff --git a/Source/web/WebPluginContainerImpl.cpp b/Source/web/WebPluginContainerImpl.cpp
index 5f5bd41aefe882ae08f1652521b96cdec90ed94a..ff820480c4b8ae545242cf49d3f938ede5046f39 100644
--- a/Source/web/WebPluginContainerImpl.cpp
+++ b/Source/web/WebPluginContainerImpl.cpp
@@ -384,17 +384,15 @@ void WebPluginContainerImpl::invalidateRect(const WebRect& rect)
invalidateRect(static_cast<IntRect>(rect));
}
-void WebPluginContainerImpl::scrollRect(int dx, int dy, const WebRect& rect)
+void WebPluginContainerImpl::scrollRect(const WebRect& rect)
{
Widget* parentWidget = parent();
if (parentWidget->isFrameView()) {
FrameView* parentFrameView = toFrameView(parentWidget);
if (!parentFrameView->isOverlapped()) {
- IntRect damageRect = convertToContainingWindow(static_cast<IntRect>(rect));
- IntSize scrollDelta(dx, dy);
- // scroll() only uses the second rectangle, clipRect, and ignores the first
- // rectangle.
- parent()->hostWindow()->scroll(scrollDelta, damageRect, damageRect);
+ // FIXME: parameter is unused. Remove once popups scroll like everything else.
+ static const IntRect dummy;
+ parent()->hostWindow()->scroll(dummy);
return;
}
}

Powered by Google App Engine
This is Rietveld 408576698