Issue 348153002: Add faster powf approximation for Android.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348153002: Add faster powf approximation for Android. (Closed)

Created:
6 years, 6 months ago by jvanverth1

Modified:
6 years, 5 months ago

Reviewers:
bungeman-skia, bsalomon

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Visibility:
Public.

More Reviews

Description

(Was: Add faster powf approximation for Android). Remove unnecessary gamma correction for A8 LCD -- should remove unnecessary calls to powf as well.

Patch Set 1 #

Patch Set 2 : Ignore GMs for change #

Patch Set 3 : Remove unnecessary gamma correction #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+93 lines, -7 lines)			Patch
	M	expectations/gm/ignored-tests.txt	View	1 2	1 chunk	+89 lines, -0 lines	0 comments	Download
	M	src/core/SkPaint.cpp	View	1 2	1 chunk	+4 lines, -7 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

bungeman-skia

I think we can do way better by just caching the value in the one ...

6 years, 6 months ago (2014-06-24 16:04:46 UTC) #2

jvanverth1

6 years, 6 months ago (2014-06-25 21:17:07 UTC) #3

I've updated it to take Ben's offline comments into account. That said, when I
ran a telemetry test on my Nexus 7, I got results indicating that this was
slower than the original code, which makes no sense. I won't be able to take
another look at this until Monday, but it may be worth a try on the Moto E, to
see if it helps there.

Expand Messages | Collapse Messages