Issue 348113004: Roll libvpx 278497:278986

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348113004: Roll libvpx 278497:278986 (Closed)

Created:
6 years, 6 months ago by fgalligan

Modified:
6 years, 6 months ago

Reviewers:
Ronghua Wu (Left Chromium), fgalligan1, Tom Finegan

CC:
chromium-reviews, scherkus (not reviewing), xhwang, bankoski, hkuang, jzern

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

More Reviews

Description

Roll libvpx 278497:278986 See https://codereview.chromium.org/341293003 https://codereview.chromium.org/343233003/ https://codereview.chromium.org/341353002/ https://codereview.chromium.org/341343004/ https://codereview.chromium.org/350543003/ for the actual changes. BUG=386801 R=ronghuawu@chromium.org, tomfinegan@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=279262

Patch Set 1 #

Patch Set 2 : libvpx:278826 #

Patch Set 3 : libvpx:278852 #

Patch Set 4 : libvpx:278875 #

Patch Set 5 : libvpx:278986 #

Patch Set 6 : Rebase #

Patch Set 7 : Rebase #

Patch Set 8 : Rebase #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	DEPS	View	1 2 3 4 5 6	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Tom Finegan

Committed patchset #8 manually as r279262 (presubmit successful).

6 years, 6 months ago (2014-06-24 01:37:36 UTC) #4

mcasas

6 years, 6 months ago (2014-06-24 08:24:11 UTC) #5

Message was sent while issue was closed.

A revert of this CL has been created in
https://codereview.chromium.org/349413002/ by mcasas@chromium.org.

The reason for reverting is: Suspected compile problem, f.i. [1]

ninja -C /b/build/slave/mac/build/src/out/Release ninja: Entering directory
`/b/build/slave/mac/build/src/out/Release' ninja: error:
'../../third_party/libvpx/source/libvpx-internal/vp8/encoder/x86/quantize_sse4.asm',
needed by 'gen/third_party/libvpx/quantize_sse4.o', missing and no known rule to
make it program finished with exit code 1 elapsedTime=2.565863


[1] 
http://master.chrome.corp.google.com:8010/builders/mac/builds/2820/steps/comp....

Expand Messages | Collapse Messages