Make cc output surface creation async

cc/test/fake_layer_tree_host.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "cc/test/fake_layer_tree_host.h"
 
 namespace cc {
-FakeLayerTreeHost::FakeLayerTreeHost(LayerTreeHostClient* client,
+FakeLayerTreeHost::FakeLayerTreeHost(FakeLayerTreeHostClient* client,

[danakj, 2014/06/20 23:36:34]

Maybe we should consider having FakeLayerTreeHost own a LayerTreeHost so it can
own the client instead of making us change every unit test. For the things it
overrides it could have a subclass of LTH that it actually owns internally.
WDYT?

[enne (OOO), 2014/06/23 16:57:39]

I went down that path a little, but it was an even bigger change than this one.

[danakj, 2014/06/25 17:43:08]

Darn :( I don't like forcing so many unrelated-to-OS-creation tests to have to
change for this. Maybe we can look into isolating this better in the future.

                                      const LayerTreeSettings& settings)
     : LayerTreeHost(client, NULL, settings),
+      client_(client),
       host_impl_(settings, &proxy_, &manager_),
-      needs_commit_(false) {}
-
-scoped_ptr<FakeLayerTreeHost> FakeLayerTreeHost::Create() {
-  static FakeLayerTreeHostClient client(FakeLayerTreeHostClient::DIRECT_3D);
-  static LayerTreeSettings settings;
-  return make_scoped_ptr(new FakeLayerTreeHost(&client, settings));
+      needs_commit_(false) {
+  client_->SetLayerTreeHost(this);
 }
 
 scoped_ptr<FakeLayerTreeHost> FakeLayerTreeHost::Create(
+    FakeLayerTreeHostClient* client) {
+  LayerTreeSettings settings;
+  return make_scoped_ptr(new FakeLayerTreeHost(client, settings));
+}
+
+scoped_ptr<FakeLayerTreeHost> FakeLayerTreeHost::Create(
+    FakeLayerTreeHostClient* client,
     const LayerTreeSettings& settings) {
-  static FakeLayerTreeHostClient client(FakeLayerTreeHostClient::DIRECT_3D);
-  return make_scoped_ptr(new FakeLayerTreeHost(&client, settings));
+  return make_scoped_ptr(new FakeLayerTreeHost(client, settings));
+}
+
+FakeLayerTreeHost::~FakeLayerTreeHost() {
+  client_->SetLayerTreeHost(NULL);
 }
 
 void FakeLayerTreeHost::SetNeedsCommit() { needs_commit_ = true; }
 
 LayerImpl* FakeLayerTreeHost::CommitAndCreateLayerImplTree() {
   scoped_ptr<LayerImpl> old_root_layer_impl = active_tree()->DetachLayerTree();
 
   scoped_ptr<LayerImpl> layer_impl = TreeSynchronizer::SynchronizeTrees(
       root_layer(), old_root_layer_impl.Pass(), active_tree());
   TreeSynchronizer::PushProperties(root_layer(), layer_impl.get());
 
   active_tree()->SetRootLayer(layer_impl.Pass());
   return active_tree()->root_layer();
 }
 
 }  // namespace cc