Issue 348039: Add comparison operations to the fast compiler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348039: Add comparison operations to the fast compiler. (Closed)

Created:
11 years, 1 month ago by William Hesse

Modified:
9 years, 7 months ago

Reviewers:
Kevin Millikin (Chromium), fschneider

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/branches/bleeding_edge/

Visibility:
Public.

Description

Add comparison operations to the fast compiler.

Patch Set 2 : '' #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+486 lines, -8 lines)			Patch
M	src/arm/fast-codegen-arm.cc	View	1	1 chunk	+165 lines, -0 lines	0 comments	Download
M	src/compiler.cc	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	src/fast-codegen.cc	View		1 chunk	+0 lines, -5 lines	0 comments	Download
M	src/ia32/fast-codegen-ia32.cc	View	1	1 chunk	+158 lines, -0 lines	0 comments	Download
M	src/x64/codegen-x64.cc	View		1 chunk	+2 lines, -2 lines	0 comments	Download
M	src/x64/fast-codegen-x64.cc	View	1	1 chunk	+158 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

fschneider

LGTM. http://codereview.chromium.org/348039/diff/1/4 File src/x64/fast-codegen-x64.cc (right): http://codereview.chromium.org/348039/diff/1/4#newcode48 Line 48: // o rbp: ouur caller's frame pointer ...

11 years, 1 month ago (2009-11-02 14:54:32 UTC) #2

Kevin Millikin (Chromium)

11 years, 1 month ago (2009-11-02 15:28:42 UTC) #3

http://codereview.chromium.org/348039/diff/1/2
File src/ia32/fast-codegen-ia32.cc (right):

http://codereview.chromium.org/348039/diff/1/2#newcode1132
Line 1132: 
Extra whitespace.

http://codereview.chromium.org/348039/diff/1/2#newcode1271
Line 1271: __ jmp(saved_true);
Indentation off.

Expand Messages | Collapse Messages

Issue 348039: Add comparison operations to the fast compiler. (Closed)

Description

Patch Set 1 #

Patch Set 2 : '' #

Messages