sdk/lib/_internal/pub/lib/src/entrypoint.dart - Issue 34803006: Make pubspec.lock keep relative path if it is originally specified as relative in pubspec.yaml (iss…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: sdk/lib/_internal/pub/lib/src/entrypoint.dart

Issue 34803006: Make pubspec.lock keep relative path if it is originally specified as relative in pubspec.yaml (iss… (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: Improve code according to the code review comments Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: sdk/lib/_internal/pub/lib/src/entrypoint.dart

diff --git a/sdk/lib/_internal/pub/lib/src/entrypoint.dart b/sdk/lib/_internal/pub/lib/src/entrypoint.dart

index c743b3a72c0718c478619e8e6d443cb48d12bb0f..e9e513fa5cee72e9da235ee93ec3444ed369335f 100644

--- a/sdk/lib/_internal/pub/lib/src/entrypoint.dart

+++ b/sdk/lib/_internal/pub/lib/src/entrypoint.dart

@@ -238,7 +238,7 @@ class Entrypoint {

}

var lockFilePath = path.join(root.dir, 'pubspec.lock');

- writeTextFile(lockFilePath, lockFile.serialize());

+ writeTextFile(lockFilePath, lockFile.serialize(root.dir, cache.sources));

}

/// Creates a self-referential symlink in the `packages` directory that allows

« no previous file with comments | « no previous file | sdk/lib/_internal/pub/lib/src/lock_file.dart » ('j') | no next file with comments »