Issue 34803004: Fix a test warning on some linux machines

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 34803004: Fix a test warning on some linux machines (Closed)

Created:
7 years, 2 months ago by edisonn

Modified:
7 years, 2 months ago

Reviewers:
sugoi

CC:
skia-review_googlegroups.com

Base URL:
https://skia.googlecode.com/svn/trunk

Visibility:
Public.

Created: 7 years, 2 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	tests/DocumentTest.cpp	View		1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 5 (0 generated)

sugoi

Works fine. LGTM The warning was only on release build using gcc. When using clang, ...

7 years, 2 months ago (2013-10-22 16:55:40 UTC) #2

sugoi

On 2013/10/22 16:55:40, sugoi wrote: > Works fine. LGTM > > The warning was only ...

7 years, 2 months ago (2013-10-22 16:57:59 UTC) #3

commit-bot: I haz the power

No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...

7 years, 2 months ago (2013-10-22 17:06:42 UTC) #4

edisonn

7 years, 2 months ago (2013-10-22 18:33:24 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 manually as r11910 (presubmit successful).