Issue 348001: Add a check to make sure we never mis-report being in context while creating ...

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 348001: Add a check to make sure we never mis-report being in context while creating ... (Closed)

Created:
11 years, 1 month ago by dglazkov

Modified:
9 years, 6 months ago

Reviewers:
Mads Ager (chromium)

CC:
v8-dev

Base URL:
http://v8.googlecode.com/svn/trunk/

Visibility:
Public.

Description

Add a check to make sure we never mis-report being in context while creating it anew. Occasionally, creating new context may trigger garbage collection, which in turn reaches back into V8 bindings during the prologue, where we can occasionally call ask for context, which makes us use incomplete context (or ASSERT in Debug). R=ager BUG=25747 TEST=random crashes on build bots should go away.

Patch Set 1 #

Created: 11 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	src/api.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mads Ager (chromium)

11 years, 1 month ago (2009-10-29 08:56:50 UTC) #2

This seems like a symptom rather than the cause.  I think there are some context
scopes missing in the WebKit/V8 bindings.  I'll investigate.

Expand Messages | Collapse Messages