Issue 347983004: Revert 278589 "Use ImageSkiaSource to create ImageSkia from Imag..."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347983004: Revert 278589 "Use ImageSkiaSource to create ImageSkia from Imag..." (Closed)

Created:
6 years, 6 months ago by ricow1

Modified:
6 years, 6 months ago

Reviewers:
oshima

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/

Visibility:
Public.

More Reviews

Description

Revert 278589 "Use ImageSkiaSource to create ImageSkia from Imag..." This seems to be the cause for gfs failures on ios simulator dbg See: http://build.chromium.org/p/chromium.mac/builders/iOS%20Simulator%20%28dbg%29/builds/16784 > Use ImageSkiaSource to create ImageSkia from ImagePNGReps > gfx::ImageKia will fetch the ImageSkiaRep based on resource scale factor (supported one) and scale accordingly. > > BUG=381601 > TEST=covered by test. > R=ananta@chromium.org, pkotwicz@chromium.org, rsesek@chromium.org > > Review URL: https://codereview.chromium.org/340613004 TBR=oshima@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278651

Patch Set 1 #

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+35 lines, -109 lines)			Patch
M	trunk/src/ui/gfx/image/image.cc	View	14 chunks	+33 lines, -95 lines	0 comments	Download
M	trunk/src/ui/gfx/image/image_unittest.cc	View	1 chunk	+2 lines, -12 lines	0 comments	Download
M	trunk/src/ui/gfx/image/image_unittest_util.cc	View	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

oshima

6 years, 6 months ago (2014-06-20 16:21:33 UTC) #3

Could you please include the reason for the revert? I've got successful try
runs (see patch set #4) and can't troubleshoot without more info.

On Fri, Jun 20, 2014 at 1:49 AM, <ricow@google.com> wrote:

> Committed patchset #1 manually as r278651.
>
> https://codereview.chromium.org/347983004/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

Expand Messages | Collapse Messages