Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 347973002: Files.app: don't refresh metadata when unnecessary (Closed)

Created:
6 years, 6 months ago by yoshiki
Modified:
6 years, 6 months ago
Reviewers:
hirono
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yoshiki+watch_chromium.org
Project:
chromium
Visibility:
Public.

Description

Files.app: don't refresh metadata when unnecessary r276293 had introduced the force refresh but it did refresh even when unnecessary. This patch make it refresh metadata only when necessary. BUG=386939 TEST=manually tested Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278726

Patch Set 1 #

Total comments: 2

Patch Set 2 : Addressed the comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -24 lines) Patch
M ui/file_manager/file_manager/foreground/js/directory_contents.js View 1 5 chunks +19 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/directory_model.js View 15 chunks +29 lines, -17 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_manager.js View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
yoshiki
@hirono, PTAL. Thanks.
6 years, 6 months ago (2014-06-20 06:59:35 UTC) #1
hirono
lgtm with a nit. https://codereview.chromium.org/347973002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js File ui/file_manager/file_manager/foreground/js/directory_contents.js (right): https://codereview.chromium.org/347973002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js#newcode721 ui/file_manager/file_manager/foreground/js/directory_contents.js:721: * @param {function(Object)} callback Callback ...
6 years, 6 months ago (2014-06-20 07:27:23 UTC) #2
yoshiki
Thanks! https://codereview.chromium.org/347973002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js File ui/file_manager/file_manager/foreground/js/directory_contents.js (right): https://codereview.chromium.org/347973002/diff/1/ui/file_manager/file_manager/foreground/js/directory_contents.js#newcode721 ui/file_manager/file_manager/foreground/js/directory_contents.js:721: * @param {function(Object)} callback Callback on done. On ...
6 years, 6 months ago (2014-06-20 07:57:02 UTC) #3
yoshiki
The CQ bit was checked by yoshiki@chromium.org
6 years, 6 months ago (2014-06-20 07:57:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/yoshiki@chromium.org/347973002/20001
6 years, 6 months ago (2014-06-20 08:00:01 UTC) #5
commit-bot: I haz the power
6 years, 6 months ago (2014-06-20 16:59:23 UTC) #6
Message was sent while issue was closed.
Change committed as 278726

Powered by Google App Engine
This is Rietveld 408576698