Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(376)

Issue 347893002: Deprecate disable_egl_khr_fence_sync on future Android releases (Closed)

Created:
6 years, 6 months ago by no sievers
Modified:
6 years, 6 months ago
Reviewers:
Zhenyao Mo
CC:
chromium-reviews, piman+watch_chromium.org, boliu, reveman
Project:
chromium
Visibility:
Public.

Description

Deprecate disable_egl_khr_fence_sync on future Android releases NOTRY=True Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278515

Patch Set 1 #

Total comments: 2

Patch Set 2 : comment #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -9 lines) Patch
M gpu/config/gpu_driver_bug_list_json.cc View 1 5 chunks +25 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
no sievers
ptal
6 years, 6 months ago (2014-06-19 21:31:00 UTC) #1
Zhenyao Mo
LGTM https://codereview.chromium.org/347893002/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/347893002/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode998 gpu/config/gpu_driver_bug_list_json.cc:998: "description": "Testing EGL sync fences is broken on ...
6 years, 6 months ago (2014-06-19 21:37:25 UTC) #2
no sievers
https://codereview.chromium.org/347893002/diff/1/gpu/config/gpu_driver_bug_list_json.cc File gpu/config/gpu_driver_bug_list_json.cc (right): https://codereview.chromium.org/347893002/diff/1/gpu/config/gpu_driver_bug_list_json.cc#newcode998 gpu/config/gpu_driver_bug_list_json.cc:998: "description": "Testing EGL sync fences is broken on IMG", ...
6 years, 6 months ago (2014-06-19 21:40:37 UTC) #3
Zhenyao Mo
LGTM again.
6 years, 6 months ago (2014-06-19 21:46:25 UTC) #4
no sievers
The CQ bit was checked by sievers@chromium.org
6 years, 6 months ago (2014-06-19 22:41:25 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sievers@chromium.org/347893002/20001
6 years, 6 months ago (2014-06-19 22:43:28 UTC) #6
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 22:46:06 UTC) #7
Message was sent while issue was closed.
Change committed as 278515

Powered by Google App Engine
This is Rietveld 408576698