Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Unified Diff: runtime/vm/compiler.cc

Issue 347873002: Ensure that a javascript compatibility warning results in a (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
===================================================================
--- runtime/vm/compiler.cc (revision 37514)
+++ runtime/vm/compiler.cc (working copy)
@@ -60,8 +60,6 @@
DECLARE_FLAG(bool, trace_failed_optimization_attempts);
DECLARE_FLAG(bool, trace_patching);
-DECLARE_FLAG(bool, warn_on_javascript_compatibility);
-DECLARE_FLAG(bool, warning_as_error);
// Compile a function. Should call only if the function has not been compiled.
// Arg0: function object.
@@ -613,9 +611,7 @@
OS::Print("%s\n", error.ToErrorCString());
}
done = true;
- ASSERT(optimized ||
- (FLAG_warn_on_javascript_compatibility &&
- FLAG_warning_as_error));
+ ASSERT(optimized);
}
// Clear the error if it was not a real error, but just a bailout.
@@ -801,14 +797,7 @@
function.SetIsOptimizable(false);
return Error::null();
}
- // So far, the only possible real error is a JS warning reported as error.
- ASSERT(FLAG_warn_on_javascript_compatibility && FLAG_warning_as_error);
- Error& error = Error::Handle();
- // We got an error during compilation.
- error = isolate->object_store()->sticky_error();
- ASSERT(!error.IsNull());
- isolate->object_store()->clear_sticky_error();
- return error.raw();
+ UNREACHABLE();
}
per_compile_timer.Stop();
« no previous file with comments | « no previous file | runtime/vm/flow_graph_builder.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698