Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1012)

Unified Diff: ui/keyboard/keyboard_controller.h

Issue 34783006: Add --keyboard-usability-test flag and always show keyboard unless manually hide (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase(no need to review diff) Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/keyboard/keyboard_controller.h
diff --git a/ui/keyboard/keyboard_controller.h b/ui/keyboard/keyboard_controller.h
index 02212a274a291e94cdbe06699179ef6672ace872..93f4902d07d51de0c54298159c03071b900d00b1 100644
--- a/ui/keyboard/keyboard_controller.h
+++ b/ui/keyboard/keyboard_controller.h
@@ -13,6 +13,8 @@
#include "ui/base/ime/input_method_observer.h"
#include "ui/keyboard/keyboard_export.h"
+class CommandLine;
+
namespace aura {
class Window;
}
@@ -47,6 +49,10 @@ class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
explicit KeyboardController(KeyboardControllerProxy* proxy);
virtual ~KeyboardController();
+ void set_command_line_for_testing(CommandLine* command_line) {
+ command_line_for_testing_ = command_line;
+ }
+
// Returns the container for the keyboard, which is owned by
// KeyboardController.
aura::Window* GetContainerWindow();
@@ -92,6 +98,9 @@ class KEYBOARD_EXPORT KeyboardController : public ui::InputMethodObserver,
ui::InputMethod* input_method_;
bool keyboard_visible_;
+ // If non-NULL, used in place of the real command line.
+ CommandLine* command_line_for_testing_;
+
sadrul 2013/10/24 01:21:01 You shouldn't need this. See comment in test.
bshe 2013/10/24 03:35:36 Done.
ObserverList<KeyboardControllerObserver> observer_list_;
base::WeakPtrFactory<KeyboardController> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698