Add --keyboard-usability-test flag and always show keyboard unless manually hide

ui/keyboard/keyboard_controller.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/keyboard/keyboard_controller.h"
 
 #include "base/bind.h"
+#include "base/command_line.h"
 #include "ui/aura/layout_manager.h"
 #include "ui/aura/window.h"
 #include "ui/aura/window_delegate.h"
 #include "ui/base/cursor/cursor.h"
 #include "ui/base/hit_test.h"
 #include "ui/base/ime/input_method.h"
 #include "ui/base/ime/text_input_client.h"
 #include "ui/base/ime/text_input_type.h"
 #include "ui/gfx/path.h"
 #include "ui/gfx/rect.h"
 #include "ui/gfx/skia_util.h"
 #include "ui/keyboard/keyboard_controller_observer.h"
 #include "ui/keyboard/keyboard_controller_proxy.h"
+#include "ui/keyboard/keyboard_switches.h"
 #include "ui/keyboard/keyboard_util.h"
 
 namespace {
 
 const int kHideKeyboardDelayMs = 100;
 
 gfx::Rect KeyboardBoundsFromWindowBounds(const gfx::Rect& window_bounds) {
   const float kKeyboardHeightRatio = 0.3f;
   return gfx::Rect(
       window_bounds.x(),
@@ skipping 113 matching lines @@
     container_->SetName("KeyboardContainer");
     container_->set_owned_by_parent(false);
     container_->Init(ui::LAYER_NOT_DRAWN);
     container_->AddObserver(this);
     container_->SetLayoutManager(new KeyboardLayoutManager(container_.get()));
   }
   return container_.get();
 }
 
 void KeyboardController::HideKeyboard(HideReason reason) {
+  if (CommandLine::ForCurrentProcess()->HasSwitch(

[kevers, 2013/10/23 11:37:39]

I think this belongs right before the "keyboard_visible_ = false;
...PostDelayedTask" below.  Otherwise, the keyboard could report the wrong state
of its visibility and an artificially high stat for showing the keyboard. 
Alternatively, you could reset the keyboard_visible_ to true here before the
early return.

[sadrul, 2013/10/23 14:01:49]

Agree. It would probably be better to just set |should_show| to true when this
flag is set?

[bshe, 2013/10/23 17:08:43]

I agree with the above and have moved it before the "keyboard_visible_ = false".
There is one issue though. We depend on focus on a text input box to trigger
keyboard show. Ideally, we should not depending on it.

In that sense,  set |should_show| to true when the flag is on seems like the
right approach. But it looks like Chrome crashes before login if we directly set
|should_show| to true. And the reason seems because we try to get default
profile when keyboard initialize. But it is too early to request profile at that
point. I moved the keyboard initialization to PostProfileInit. It failed again
because TextInputClient is null at that point. Anyway, it looks like it is not
trivial to set |should_show| to true. Added a TODO and will deal with it in a
separate CL.

On 2013/10/23 14:01:49, sadrul wrote:

+      switches::kKeyboardUsabilityTest) && reason == HIDE_REASON_AUTOMATIC) {
+    return;
+  }
+
   keyboard_visible_ = false;
 
   keyboard::LogKeyboardControlEvent(
       reason == HIDE_REASON_AUTOMATIC ?
           keyboard::KEYBOARD_CONTROL_HIDE_AUTO :
           keyboard::KEYBOARD_CONTROL_HIDE_USER);
 
   FOR_EACH_OBSERVER(KeyboardControllerObserver,
                     observer_list_,
                     OnKeyboardBoundsChanging(gfx::Rect()));
@@ skipping 76 matching lines @@
     const ui::InputMethod* input_method) {
   DCHECK_EQ(input_method_, input_method);
   input_method_ = NULL;
 }
 
 bool KeyboardController::WillHideKeyboard() const {
   return weak_factory_.HasWeakPtrs();
 }
 
 }  // namespace keyboard