Issue 347813004: Clear active splice flag after an explicit Reset().

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 347813004: Clear active splice flag after an explicit Reset(). (Closed)

Created:
6 years, 6 months ago by DaleCurtis

Modified:
6 years, 6 months ago

Reviewers:
xhwang

CC:
chromium-reviews, feature-media-reviews_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Project:
chromium

Visibility:
Public.

Clear active splice flag after an explicit Reset(). When Reset() is called outside of a config change, we need to clear the active splice flag. BUG=386782 TEST=new unittest R=xhwang@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278816

Created: 6 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+31 lines, -0 lines)			Patch
M	media/filters/decoder_stream.cc	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	media/filters/fake_demuxer_stream.h	View	2 chunks	+6 lines, -0 lines	0 comments	Download
M	media/filters/fake_demuxer_stream.cc	View	2 chunks	+2 lines, -0 lines	0 comments	Download
M	media/filters/video_frame_stream_unittest.cc	View	3 chunks	+22 lines, -0 lines	0 comments	Download

Total messages: 6 (0 generated)

DaleCurtis

xhwang: This is pretty similar to the bug you just fixed in your EOS-removal CL ...

6 years, 6 months ago (2014-06-20 00:23:45 UTC) #1

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dalecurtis@chromium.org/347813004/1

6 years, 6 months ago (2014-06-20 17:21:06 UTC) #4

commit-bot: I haz the power

FYI, CQ is re-trying this CL (attempt #1). The failing builders are: win_chromium_rel on tryserver.chromium ...

6 years, 6 months ago (2014-06-20 20:57:16 UTC) #5

DaleCurtis

6 years, 6 months ago (2014-06-20 21:00:45 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 manually as r278816 (presubmit successful).