Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(611)

Issue 347813002: Added ignored_by_shelf bit to overview mode selection widget. (Closed)

Created:
6 years, 6 months ago by Nina
Modified:
6 years, 6 months ago
Reviewers:
flackr, tdanderson
CC:
chromium-reviews, tdanderson+overview_chromium.org, kalyank, sadrul, ben+ash_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Added ignored_by_shelf bit to overview mode selection widget. This change enables the selection widget to pass under the shelf without activating it. BUG=367766 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278479

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M ash/wm/overview/window_grid.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Nina
Hi Rob, please review this 3 lines patch.
6 years, 6 months ago (2014-06-19 16:53:39 UTC) #1
flackr
4 lines including empty line :-). lgtm.
6 years, 6 months ago (2014-06-19 17:10:55 UTC) #2
tdanderson
The CQ bit was checked by tdanderson@chromium.org
6 years, 6 months ago (2014-06-19 17:21:16 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nsatragno@chromium.org/347813002/1
6 years, 6 months ago (2014-06-19 17:22:43 UTC) #4
commit-bot: I haz the power
6 years, 6 months ago (2014-06-19 20:58:31 UTC) #5
Message was sent while issue was closed.
Change committed as 278479

Powered by Google App Engine
This is Rietveld 408576698