Move UpdateActivePermissions from ExtensionService to PermissionsUpdater

Move UpdateActivePermissions from ExtensionService to PermissionsUpdater
This method doesn't belong in ExtensionService, and can instead live in
PermissionsUpdater. This helps keep the permissions updating logic together.

Also update PermissionsUpdater to use a browser context instead of a profile,
where possible.

BUG=351891
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=278832

[Devlin, 2014-06-19 23:07:44]

A nice short one. :)

[Yoyo Zhou, 2014-06-20 16:13:39]

LGTM

https://codereview.chromium.org/347803005/diff/1/chrome/browser/extensions/pe...
File chrome/browser/extensions/permissions_updater.h (right):

https://codereview.chromium.org/347803005/diff/1/chrome/browser/extensions/pe...
chrome/browser/extensions/permissions_updater.h:51: void
UpdateActivePermissions(const Extension* extension);
This only gets called in the flow from AddPermissions. I feel
InitializeActivePermissions would be a better name.

[Devlin, 2014-06-20 17:05:30]

https://codereview.chromium.org/347803005/diff/1/chrome/browser/extensions/pe...
File chrome/browser/extensions/permissions_updater.h (right):

https://codereview.chromium.org/347803005/diff/1/chrome/browser/extensions/pe...
chrome/browser/extensions/permissions_updater.h:51: void
UpdateActivePermissions(const Extension* extension);
On 2014/06/20 16:13:39, Yoyo Zhou wrote:
> This only gets called in the flow from AddPermissions. I feel
> InitializeActivePermissions would be a better name.

Done.

(I assume you meant "called in the flow from AddExtension".)

[Devlin, 2014-06-20 17:05:41]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2014-06-20 17:10:29]

CQ is trying da patch. Follow status at

https://chromium-status.appspot.com/cq/rdevlin.cronin@chromium.org/347803005/...

[Yoyo Zhou, 2014-06-20 18:53:39]

On 2014/06/20 17:05:30, Devlin wrote:
>
https://codereview.chromium.org/347803005/diff/1/chrome/browser/extensions/pe...
> File chrome/browser/extensions/permissions_updater.h (right):
> 
>
https://codereview.chromium.org/347803005/diff/1/chrome/browser/extensions/pe...
> chrome/browser/extensions/permissions_updater.h:51: void
> UpdateActivePermissions(const Extension* extension);
> On 2014/06/20 16:13:39, Yoyo Zhou wrote:
> > This only gets called in the flow from AddPermissions. I feel
> > InitializeActivePermissions would be a better name.
> 
> Done.
> 
> (I assume you meant "called in the flow from AddExtension".)

That's correct, sorry.

[commit-bot: I haz the power, 2014-06-20 20:22:52]

FYI, CQ is re-trying this CL (attempt #1).
The failing builders are:
  android_dbg_triggered_tests on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered...)

[commit-bot: I haz the power, 2014-06-20 21:50:54]

Change committed as 278832