chrome/test/nacl/nacl_browsertest.cc - Issue 347803004: Ensure the OSX crash catcher does not trigger on SIGABRT when disabled.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/nacl/nacl_browsertest.cc

Issue 347803004: Ensure the OSX crash catcher does not trigger on SIGABRT when disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Edit Created 6 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/test/nacl/nacl_browsertest.cc

diff --git a/chrome/test/nacl/nacl_browsertest.cc b/chrome/test/nacl/nacl_browsertest.cc

index cfbe37c65fe24b8f7057238e64dcc42c0310805d..377640d460a869e63331c545dd0ac7681169a007 100644

--- a/chrome/test/nacl/nacl_browsertest.cc

+++ b/chrome/test/nacl/nacl_browsertest.cc

@@ -87,9 +87,7 @@ NACL_BROWSER_TEST_F(NaClBrowserTest, ProgressEvents, {

// allowed. Also not run on GLibc because it's a large test that is at risk of

// causing timeouts.

// crbug/338444

-// crbug.com/375103: fails on Mac after open sourcing PDF plugin.

-// crbug.com/375103: fails on Linux too after open sourcing PDF plugin.

-#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)

+#if defined(OS_WIN)

#define MAYBE_Bad DISABLED_Bad

#else

#define MAYBE_Bad Bad

« no previous file with comments | « chrome/test/data/nacl/bad/ppapi_bad.html ('k') | no next file » | no next file with comments »