Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(566)

Unified Diff: base/mac/os_crash_dumps.cc

Issue 347803004: Ensure the OSX crash catcher does not trigger on SIGABRT when disabled. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Edit Created 6 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/data/nacl/bad/ppapi_bad.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/mac/os_crash_dumps.cc
diff --git a/base/mac/os_crash_dumps.cc b/base/mac/os_crash_dumps.cc
index e50ac3974215d995be9eef7b4deeb4fe0d8c2e1a..5d65b469dddaf3932a97366b919415cc00e10a33 100644
--- a/base/mac/os_crash_dumps.cc
+++ b/base/mac/os_crash_dumps.cc
@@ -30,11 +30,14 @@ void DisableOSCrashDumps() {
// bsd/uxkern/ux_exception.c and machine_exception() in xnu's
// bsd/dev/*/unix_signal.c.
const int signals_to_intercept[] = {
+ // Hardware faults
SIGILL, // EXC_BAD_INSTRUCTION
SIGTRAP, // EXC_BREAKPOINT
SIGFPE, // EXC_ARITHMETIC
SIGBUS, // EXC_BAD_ACCESS
- SIGSEGV // EXC_BAD_ACCESS
+ SIGSEGV, // EXC_BAD_ACCESS
+ // Not a hardware fault
+ SIGABRT
};
// For all these signals, just wire things up so we exit immediately.
« no previous file with comments | « no previous file | chrome/test/data/nacl/bad/ppapi_bad.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698