Ensure the OSX crash catcher does not trigger on SIGABRT when disabled.

chrome/test/nacl/nacl_browsertest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <stdio.h>
 #if defined(OS_POSIX)
 #include <unistd.h>
 #elif defined(OS_WIN)
 #include <windows.h>
 #endif
@@ skipping 69 matching lines @@
 NACL_BROWSER_TEST_F(NaClBrowserTest, ProgressEvents, {
   RunNaClIntegrationTest(FILE_PATH_LITERAL("ppapi_progress_events.html"));
 })
 
 // Note: currently not run on PNaCl because crash throttling causes the last few
 // tests to fail for the wrong reasons.  Enabling this test would also require
 // creating a new set of manifests because shared NaCl/PNaCl manifests are not
 // allowed.  Also not run on GLibc because it's a large test that is at risk of
 // causing timeouts.
 // crbug/338444
-// crbug.com/375103: fails on Mac after open sourcing PDF plugin.
-// crbug.com/375103: fails on Linux too after open sourcing PDF plugin.

[Mark Seaborn, 2014/06/19 18:28:14]

This issue seems unrelated, since Linux wouldn't be affected by
base/mac/os_crash_dumps.cc.  Not sure if it's safe to re-enable this for Linux.

Any idea what was going on with the PDF plugin?

[Nick Bray (chromium), 2014/06/19 18:38:05]

The only reason open sourcing the PDF plugin affected this test was because
there were two "visual tests" that used a pdf mimetype.  I didn't bother digging
into it because  1) visual tests in an otherwise automated test are stupid and
2) trying to use a mimetype that may already be registered is stupid.  So, with
so much obvious stupid on the table, I saw no real reason to dig into this -
just remove the code in question.

That being said, this test is the best test we have for this bug, and it needed
to be re-enabled.  So yes, it's also being re-enabled for Linux but the reasons
it was disabled were trivial, so it's not a huge leap.

[Mark Seaborn, 2014/06/19 22:14:32]

OK, I see now.  That wasn't obvious from the commit message.  Can you explain
that in the commit message, please?  i.e. Explain why changing ppapi_bad.html
fixes the issue.  Then LGTM.

-#if defined(OS_WIN) || defined(OS_MACOSX) || defined(OS_LINUX)
+#if defined(OS_WIN)
 #define MAYBE_Bad DISABLED_Bad
 #else
 #define MAYBE_Bad Bad
 #endif
 IN_PROC_BROWSER_TEST_F(NaClBrowserTestNewlib, MAYBE_Bad) {
   RunNaClIntegrationTest(FILE_PATH_LITERAL("ppapi_bad.html"));
 }
 
 // partially_invalid.c does not have an ARM version of its asm.
 #if !defined(__arm__)
@@ skipping 348 matching lines @@
 #define MAYBE_MimeHandler DISABLED_MimeHandler
 #else
 #define MAYBE_MimeHandler MimeHandler
 #endif
 IN_PROC_BROWSER_TEST_F(NaClBrowserTestNewlibExtension, MAYBE_MimeHandler) {
   RunNaClIntegrationTest(FILE_PATH_LITERAL(
       "ppapi_extension_mime_handler.html"));
 }
 
 }  // namespace